Skip to content

Disallow local client to addref themselves #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ILW8 merged 2 commits into from
Feb 16, 2026
Merged

Disallow local client to addref themselves #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cbe354
Lists the host as the referee and disallows for the host to be addref…
Decordy Feb 14, 2026
282cb31
wth is this why is it here...
Decordy Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion osu.Game/Online/Chat/StandAloneChatDisplay.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,12 +700,13 @@ private void postMessage(TextBox sender, bool newText)
}
else
{
void printRefsList() => EnqueueBotMessage($@"Match referees: {string.Join(", ", multiplayerRefereeTracker.Referees)}");
void printRefsList() => EnqueueBotMessage($@"Match referees: {string.Join(", ", new[] { API.LocalUser.Value }.Concat(multiplayerRefereeTracker.Referees))}");

switch (parts.Length)
{
// special-case addref. only handle it locally
case 3 when parts[1] == @"addref":
APIUser? localUser = API.LocalUser.Value;
queryUsername(parts[2]).ContinueWith(t =>
{
APIUser? user = t.GetResultSafely();
Expand All @@ -716,6 +717,12 @@ private void postMessage(TextBox sender, bool newText)
return;
}

if (user.Id == localUser.Id)
{
EnqueueBotMessage(@"You can't addref yourself. Just make sure you have the host.");
return;
}

multiplayerRefereeTracker.AddRef(user);
printRefsList();
});
Expand Down