Conversation
| description: 'A GitHub auth token to be able to create the pull request' | ||
| required: true | ||
| gradle-path: | ||
| version-filepath: |
There was a problem hiding this comment.
I would leave this as gradle-path, as it better describes what its relating to, the use of "version" is not particularly clear, also this could be a breaking change where as all the other changes are not breaking, and its specific to gradle, whereas we also deal with pom's in this script but we don't use the variable for poms
There was a problem hiding this comment.
Yeah. well; I did not find where we were using this gradle-path to begin with. So having it and using it instead of having it and not using it is 100% an improvement.
This being said, there is no good reason to:
- rename it to
version-filepath(and lose the "coupling" to Gradle) - so far so good... - add it to the Gradle part of the code - yep, great, thank you..
- not do it for the Maven part...
I mean supporting the Maven part of this is not the most fun, but it's out there, and if you go down the route of un-specialising those variable/property names, that's fine, but if you do, you really need to do the Maven part.
If not, then keep it gradle-path and let us be happy with the improvement on the Gradle part of the tool.
| GIT_COMMITTER_NAME: ${{ steps.config.outputs.git-committer-username }} | ||
| GIT_COMMITTER_EMAIL: ${{ steps.config.outputs.git-committer-email }} | ||
| CURRENT_VERSION: ${{ steps.config.outputs.current-version }} | ||
| VERSION_FILEPATH: ${{ steps.config.outputs.version-filepath }} |
There was a problem hiding this comment.
RELATIVE_GRADLE_FILEPATH would be better
There was a problem hiding this comment.
Agreed, assuming the change is not done on the Maven part of the tool. If it is, then the new name is fine.
3 participants
No description provided.