Skip to content

Conversation

@remdub
Copy link
Member

@remdub remdub commented Oct 6, 2025

CITI-15

@remdub remdub requested a review from Copilot October 6, 2025 09:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds functionality to clean TypeScript API URLs in the registry, ensuring only base URLs are stored. It implements an upgrade step that extracts and normalizes base URLs from potentially longer API endpoint URLs.

  • Adds utility function to extract base URL from TS API URLs using URL parsing
  • Implements upgrade step to clean existing TS API URLs in the registry
  • Includes comprehensive test coverage for the new utility function

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/imio/smartweb/policy/utils.py Adds get_ts_api_base_url() utility function to extract base URL from TS API URLs
src/imio/smartweb/policy/upgrades/upgrades.py Implements clean_ts_api_url() upgrade step to normalize existing registry URLs
src/imio/smartweb/policy/upgrades/configure.zcml Registers the new upgrade step from version 1038 to 1039
src/imio/smartweb/policy/tests/test_utils.py Adds comprehensive unit tests for the new utility function
src/imio/smartweb/policy/profiles/default/metadata.xml Updates profile version to 1039
CHANGES.rst Documents the new feature in the changelog

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants