Skip to content

Conversation

@faberno
Copy link
Collaborator

@faberno faberno commented Nov 7, 2024

  • fixed vessel deformation bug
  • catched cosine_scaling_factor = 0 case

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

Provide issue / feature request fixed by this PR

Fixes #392

- catched cosine_scaling_factor = 0 case
jgroehl
jgroehl previously approved these changes Nov 18, 2025
Copy link
Collaborator

@jgroehl jgroehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me!

@jgroehl jgroehl changed the base branch from main to develop November 18, 2025 14:31
@jgroehl jgroehl dismissed their stale review November 18, 2025 14:31

The base branch was changed.

jgroehl
jgroehl previously approved these changes Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vessel Deformation Bug

4 participants