-
Notifications
You must be signed in to change notification settings - Fork 26
The Rayleigh Scattering is not correct. #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
P.s. I think I raised this issue a few years ago, but it didn't get fixed, so it might be worth propagating this correction to all other branches to make sure that it doesn't somehow get overwritten in future? |
|
Yes, you're absolutely right. Not only this but also, everywhere we use this function, we use it as scattering coefficient instead of the reduced scattering. We're directly testing certain scattering coefficients, so the tests shouldn't break. It seems like some builds don't run at the moment, which is a different problem, though 😅 |
|
@kdreher The tests are indeed failing because of mismatches in the created versus tested scattering. |
|
At the very least, a test should be added that tests for the correct implementation of this, such that it fails in the future when it accidentally gets reverted. Also: the windows tests should not succeed...! |
|
I have double-checked, and we are defining |
… re-happening, and adjusted the tissue value tests such that the values are in line with the paper of BASHKATOV et al., 2011 Fixes #412
|
Integrated this change with a whole test suite in PR #432 |

Your formula for Rayleigh scattering used to be ~ (lambda) ^ (1e-4), but should be ~ (lambda)^-4
I put the pull request in by just editing the GitHub text file, so haven't rerun the tests, but I can't see why this should break anything. If you have any optical tests that validate light fluence values etc, then these will need remaking I suspect.