Skip to content

Conversation

@jgroehl
Copy link
Collaborator

@jgroehl jgroehl commented Nov 18, 2025

Please check the following before creating the pull request (PR):

  • Did you run automatic tests?
  • Did you run manual tests?
  • Is the code provided in the PR still backwards compatible to previous SIMPA versions?

List any specific code review questions

List any special testing requirements

Additional context (e.g. papers, documentation, blog posts, ...)

Provide issue / feature request fixed by this PR

Fixes #

@jgroehl jgroehl changed the base branch from main to develop November 18, 2025 09:16
@jgroehl jgroehl requested a review from Copilot November 18, 2025 09:19
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Python versions tested in the CI workflow, dropping Python 3.9 and adding Python 3.13 to the test matrix.

  • Removes Python 3.9 from the CI test matrix
  • Adds Python 3.13 to the CI test matrix
  • Tests now run against Python 3.10, 3.11, 3.12, and 3.13

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fail-fast: false
matrix:
python-version: ["3.9", "3.10", "3.11", "3.12"]
python-version: ["3.10", "3.11", "3.12", "3.13"]
Copy link

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml file still specifies requires-python = ">=3.9" (line 16), but Python 3.9 is no longer being tested in CI. Please either:

  1. Update requires-python in pyproject.toml to ">=3.10" to match the tested versions, or
  2. Keep Python 3.9 in the test matrix if the package should continue supporting it.

This ensures consistency between the package's declared Python version support and what is actually tested.

Suggested change
python-version: ["3.10", "3.11", "3.12", "3.13"]
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jgroehl jgroehl changed the title T430 bumptested python versions T430 bump tested python versions Nov 18, 2025
@jgroehl jgroehl merged commit 7cb404f into develop Dec 5, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants