Upgrade to effect v3.0 #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using: `Either<([^<>,]*|[^<>,]*<[^<>]*>),\s*([^<>,]*|[^<>,]*<[^<>]*>)>`
only imports, to avoid shadowing built-in array constructor
Either comparisons needed patched equality testing added in Effect-TS/effect#2670
|
This is now solved in #9 I think.. |
Owner
|
Indeed - going to go ahead and close this issue - thank you all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi hi
this is a pretty naive effort — I'm not familiar enough with effect to understand which changes were rolled into v3.0, etc... but this gets the tests passing, and it seems to be working fine
branch includes all changes from #6 btw, so please don't merge on its lonesome