-
-
Notifications
You must be signed in to change notification settings - Fork 36
feat: Add search functionality for boxes #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Rexios80 Let me know your review on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds real-time search functionality for boxes in the Hive CE Inspector DevTools extension. When users type in the search field, the box list is filtered to show only matching boxes, with an empty state displayed when no matches are found.
Changes:
- Added a search text field above the boxes list with real-time filtering
- Implemented case-insensitive search that filters box names
- Added empty state message when no boxes match the search query
- Updated padding to be consistent (8px) across search inputs
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| hive_ce_inspector/lib/widget/connected_layout.dart | Added search controller, filtering logic, search UI, and empty state for boxes |
| hive_ce_inspector/lib/widget/box_view.dart | Updated padding from 16px to 8px for consistency with new search UI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit eb95133.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 64 64
Lines 2617 2617
=======================================
Hits 2449 2449
Misses 168 168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
|
Thanks for the contribution! This will be released in version |
This PR improves developer experience by adding real-time box search and a helpful empty state when no matches are found.