Dataset Type selection step in Create Dataset page#876
Dataset Type selection step in Create Dataset page#876
Conversation
Conflicts: package-lock.json package.json
The DropdownButtonItem disabled property depends on it.
… and New Review button
…ry and its implementations
Conflicts: package-lock.json package.json src/dataset/domain/repositories/DatasetRepository.ts src/stories/dataset/DatasetErrorMockRepository.ts src/stories/dataset/DatasetMockRepository.ts
Conflicts: src/dataset/infrastructure/repositories/DatasetJSDataverseRepository.ts src/sections/create-dataset/CreateDataset.tsx src/sections/shared/form/DatasetMetadataForm/MetadataForm/index.tsx src/sections/shared/form/DatasetMetadataForm/index.tsx src/stories/create-dataset/CreateDataset.stories.tsx src/stories/dataset/DatasetErrorMockRepository.ts src/stories/dataset/DatasetMockRepository.ts tests/component/sections/create-dataset/CreateDataset.spec.tsx tests/component/sections/layout/header/LoggedInHeaderActions.spec.tsx
I just fixed this in 7c355f4. It looks like this after running
|
|
Here are updated screenshots as of IQSS/dataverse@be670d4 where @scolapasta and I decided to make some changes to the backend. We're now using the linkedMetadataBlocks features and setting itemReviewedUrl and itemReviewedType as required=true in the tsv. In the collection below, we are allowing both "Dataset" and "Review" under "Dataset Type".
Here is the creation of a review dataset. Note that the "Review Metadata" metadata block is present, which is what we want, of course.
Here is the creation of a regular dataset. Note that the "Review Metadata" metadata block is absent. This is what we want because having "Item Reviewed" as a required field doesn't make sense for a dataset.
|
|
The PR was on hold because we were waiting for the backend code to be merged, which happened yesterday.
I moved it to "ready for review". |






What this PR does / why we need it:
Following up on @pdurbin's work in #845, this PR updates how users select the dataset type in the dataset creation flow.
For now, we’ve hardcoded the dataset type descriptions (“dataset” and “review”) as a temporary solution until the new field is added.Update: this was fixed in 7c355f4.This is the first step toward supporting dataset types in the SPA, more enhancements coming soon.
Storybook links:
Which issue(s) this PR closes:
Depends on
This PR depends on the following backend PR:
Special notes for your reviewer:
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes.
The "Create Dataset" page now has a Dataset Type dropdown. See the latest screenshots here: #876 (comment)
Is there a release notes or changelog update needed for this change?:
Not for now, might be good to add it after work related to dataset types is done.
Additional documentation: