fix of issue #13 (import failure due to failure to detect delimiter) and another possible bug (originating in revtools).#14
Open
Maelphes wants to merge 1 commit intoIQWiG:mainfrom
Open
Conversation
…er) by increasing line limit to 300. fixed formal error in delimiter detection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small change fixes an issue where the delimiter between the datasets in the import file is not located in the first 200 lines of text. The current commit increases the number of lines from 200 to 300, which at the moment appears to be sufficient.
The second change in this commit is the fix of a formal error in the delimiter detection. There is one pattern which the function recognizes as a delimiter which consists of a line containing one unique character which is repeated more than six times in a row (such as
************or-------------) . However, in the condition for the length of this pattern there is a misplaced parenthesis.The third change is the automated assignment of a ProjectId by R Studio. I am not sure this has any meaning. If this is a problem, one option would be to remove
searchbuildR.Rprojfrom the git repo and listed in.gitignore.