Open
Conversation
…ul equality properties for end user. Moved from using sets to dicts for storing internal measurement collections.
…h named parameters (e.g. distance)
…setitem__` for convience in accessing specific stored measures.
…s to framedata instead of lists.
…low for FramData (de)serialisation.
…ices for geometric measures as well.
…yErrors - rather returns None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to add a useful framework for introducing measurements to FrameData and allow for this information to be (de)serialised so it can be sent over the network.
The intended use of this framework is outlined in the new tutorial notebook ("tutorials/fundamentals/adding_measurements.ipynb").
A future PR is expected to introduce the ability to automatically compute these values and add it to sent frames.