Skip to content

Fix mISDN driver crash caused by transfer buffer on the stack #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jurodr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mISDN driver crash caused by transfer buffer on the stack #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion drivers/isdn/hardware/mISDN/hfcsusb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1705,12 +1705,22 @@ static int
setup_hfcsusb(struct hfcsusb *hw)
{
u_char b;
int ret;
void *dmabuf = kmalloc(sizeof(u_char), GFP_KERNEL);

if (debug & DBG_HFC_CALL_TRACE)
printk(KERN_DEBUG "%s: %s\n", hw->name, __func__);

if (!dmabuf)
return -ENOMEM;

ret = read_reg_atomic(hw, HFCUSB_CHIP_ID, dmabuf);

memcpy(&b, dmabuf, sizeof(u_char));
kfree(dmabuf);

/* check the chip id */
if (read_reg_atomic(hw, HFCUSB_CHIP_ID, &b) != 1) {
if (ret != 1) {
printk(KERN_DEBUG "%s: %s: cannot read chip id\n",
hw->name, __func__);
return 1;
Expand Down