[Refactor] Add subquery support for formatter#93
Open
colinthebomb1 wants to merge 4 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds formatter support for SQL subqueries and makes formatter tests compare SQL semantics by parsing (mo_sql_parsing) rather than normalizing strings.
Changes:
- Update formatter expression serialization to handle subqueries and string literals in mo_sql_parsing-compatible JSON.
- Refactor formatter tests to compare
mo_sql_parsing.parse()output instead of regex/whitespace normalization. - Add/enable a formatter test case that includes a subquery.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_query_formatter.py | Switches SQL comparisons to parse() and adds a subquery formatting test. |
| core/query_formatter.py | Extends expression formatting to emit mo_sql_parsing JSON for string literals and subqueries. |
Comments suppressed due to low confidence (1)
tests/test_query_formatter.py:84
- The PR description mentions updating
tests/test_formatter.py, but the changes/additions are actually intests/test_query_formatter.py. Please update the PR description (or rename/move the test) so the documented change matches the code.
def test_subquery_format():
# Tables
emp_table = TableNode("employee")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview:
This PR implements subquery support for the formatter, as well as simplifies the process for comparing input sql to output sql by using mosqlparse instead of string comparison with regex
Code Changes:
tests\test_formatter.pyaddedtest_subquery_format()to run a formatter test that uses a sql query containing a subquerynormalize_sqlfunction and changed input/output sql comparisons to use mosqlparse