Skip to content

Conversation

@oerc0122
Copy link
Collaborator

@oerc0122 oerc0122 commented Nov 7, 2025

Description of work
Refactor all the plotters to use generator constructs, gridspecs and attempt to reduce code-duplication.

Fixes
Prevent number of plots corresponding to number of datasets.

To test
Try to break plotting with weird sequences of button presses.

@oerc0122 oerc0122 self-assigned this Nov 7, 2025
@oerc0122 oerc0122 added the Technical Debt Legacy code which should be cleaned up. label Nov 7, 2025
@MBartkowiakSTFC
Copy link
Collaborator

I have been testing the plotter. What I found so far is:

  1. Grid plots of 1D datasets have an empty legend.
  2. If I plot into Grid or Single with legend switched off, and switch it on afterwards, I get an exception: <class 'AttributeError'> 'NoneType' object has no attribute 'set_visible'
  3. Heatmap plot is labelling the plot axes wrong. In my test, time was shown as Q and Q was shown as time.
Screenshot 2025-11-10 at 11 51 59
  1. Heatmap plots start off without any legend. If I switch legend off and on, the legend appears.
  2. If I try to plot a vector summary from the plot creator like this
Screenshot 2025-11-10 at 12 07 03

the plot type ends up being Single and not Vectors:

Screenshot 2025-11-10 at 12 06 42

While we do not want to allow Vectors plot type for normal data sets, it should still be possible to use Vectors for vectors.

  1. For Single and Heatmap plots, switching the legend off and on makes all the subplots resize.
    Before:
Screenshot 2025-11-10 at 12 18 02

After:
Screenshot 2025-11-10 at 12 18 12

@oerc0122 oerc0122 force-pushed the cleanup-plotter branch 2 times, most recently from 017e4f3 to 77472d1 Compare November 19, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Technical Debt Legacy code which should be cleaned up.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants