Slight cleanup and refactor of sliderpack #1064
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oerc0122
force-pushed
the
refactor-sliderpack
branch
from
deedc43 to
56d104a
Compare
oerc0122
force-pushed
the
refactor-sliderpack
branch
from
56d104a to
8852780
Compare
oerc0122
force-pushed
the
refactor-sliderpack
branch
from
8852780 to
27e1a1c
Compare
Collaborator
|
There is a slight functionality change. In the main branch, the sliderpack made it impossible to set heatmap maximum to be lower than minimum: After the changes, nothing can stop me: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Generalise sliderpack and reduce manual code for 2 sliders.
Fixes
N/A
To test
Sliderpack should work as normal.