Skip to content

Conversation

@martyngigg
Copy link
Contributor

@martyngigg martyngigg commented Jan 8, 2026

Summary

Updates infra/local Superset image to pull in fixes for v6 Login page issues when Superset is on a prefixed path.

Also fixes issues with trino connection string and branding logo now we have a newer docker image.

Summary by CodeRabbit

  • Chores
    • Updated analytics platform dependencies to latest versions.
    • Refined internal database configuration parameters.

✏️ Tip: You can customize this high-level summary in your review settings.

@martyngigg martyngigg enabled auto-merge (squash) January 8, 2026 14:44
@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

Three updates to the local Superset infrastructure: the container image reference was updated to a new version, the Trino database URI parameter format was modified in the Iceberg catalog configuration, and a theming workaround constant was removed from the configuration file.

Changes

Cohort / File(s) Summary
Superset container and initialisation
infra/local/docker-compose.yml, infra/local/superset/docker/docker-init.sh
Updated Superset container image reference to new version; modified Trino database URI parameter from engine_params with verify: false to direct verify=false in URI string
Superset configuration
infra/local/superset/docker/pythonpath/superset_config.py
Removed THEME_DEFAULT constant and associated theming workaround block (11 lines deleted); no replacement fallback introduced

Poem

🐰 The images are refreshed, Trino's path made sleek,
Theming workarounds gone—configuration speaks!
Docker containers updated, connections refined,
Superset local setup, now streamlined and kind. ✨


📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 655c3aa and fa6c476.

📒 Files selected for processing (3)
  • infra/local/docker-compose.yml
  • infra/local/superset/docker/docker-init.sh
  • infra/local/superset/docker/pythonpath/superset_config.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@martyngigg martyngigg merged commit abb73d6 into main Jan 8, 2026
2 of 3 checks passed
@martyngigg martyngigg deleted the fix-infra-local-superset branch January 8, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants