44 update pvrecipe to allow initialisation of custom rules using the yaml config parser #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Monarda
reviewed
Oct 29, 2025
p4pillon/config_reader.py
Outdated
|
|
||
| # Process configuration in the yaml specific to a supported rule | ||
| # and add this to pvrecipe.rule_configs | ||
| rule_configs = [("calc", dict), ("cps_write", dict)] |
Contributor
There was a problem hiding this comment.
There shouldn't be references to rules which don't exist in p4pillon in the p4pillon code! This indicates that there needs to be an alternate way to handle this, which isn't a growing list of special cases.
Contributor
There was a problem hiding this comment.
You may wish to consider entrypoints as a potential generic solution? (https://packaging.python.org/en/latest/specifications/entry-points/) I've not used them myself, so they may not be suitable. @MatInGit has used them and has this example.
Contributor
Author
There was a problem hiding this comment.
Yes I agree! I think this can be done in a similar way to how registered_handlers are defined in SharedNT (as a class member) so that external rules can be added to rule_configs.
aqshafei
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small modifications to pvrecipe and the config reader to use custom YAML configs for non-standard rules. I've also included a small change to server.put_pv_value so that puts can be done using the post method of the SharedPV if the PV exists on the server (if not a Context put is called). This allows setting a read-only PV, e.g. when updating the value from hardware.