Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 6, 2025

What do these changes do?

  • diff new compose vs old after they are composed!

Related issue/s

How to test

Dev-ops

…chemy.ext.asyncio

🗑️ Remove unused files.py dependency
📝 Clean up JobInputs model by removing outdated TODO comment
…comments in services_consume_filetypes.py and httpx_calls_capture.py; adjust webserver_service fixture scope in simcore_webserver_service.py
…ve outdated TODO comments in traefik_service.py and osparc_config.py; clean up settings.py by removing unnecessary TODOs
…inputs function; enhance type conversion using Pydantic smart unions and improve logging for unresolved parameters
…tency; enhance validation logic in validate_callable_signature function and add comprehensive tests for various scenarios
@pcrespov pcrespov self-assigned this Oct 6, 2025
@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (266c7c3) to head (5529076).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8465      +/-   ##
==========================================
- Coverage   87.69%   85.13%   -2.57%     
==========================================
  Files        1983      860    -1123     
  Lines       77277    32442   -44835     
  Branches     1333      966     -367     
==========================================
- Hits        67771    27618   -40153     
+ Misses       9107     4504    -4603     
+ Partials      399      320      -79     
Flag Coverage Δ
integrationtests 66.52% <ø> (+2.41%) ⬆️
unittests 83.98% <100.00%> (-2.41%) ⬇️
Components Coverage Δ
pkg_aws_library 93.59% <ø> (ø)
pkg_celery_library 83.76% <ø> (ø)
pkg_dask_task_models_library 79.33% <ø> (ø)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library 85.20% <ø> (ø)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 70.17% <ø> (ø)
pkg_service_library 70.92% <100.00%> (+<0.01%) ⬆️
pkg_settings_library 90.19% <ø> (ø)
pkg_simcore_sdk 84.95% <ø> (ø)
agent 93.53% <ø> (ø)
api_server ∅ <ø> (∅)
autoscaling 95.71% <ø> (ø)
catalog ∅ <ø> (∅)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 92.35% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 75.81% <ø> (ø)
director_v2 ∅ <ø> (∅)
dynamic_scheduler 96.71% <ø> (ø)
dynamic_sidecar 90.43% <ø> (ø)
efs_guardian 89.74% <ø> (ø)
invitations 91.41% <ø> (ø)
payments 92.71% <ø> (ø)
resource_usage_tracker 91.88% <ø> (-0.33%) ⬇️
storage 86.74% <ø> (+0.29%) ⬆️
webclient ∅ <ø> (∅)
webserver ∅ <ø> (∅)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266c7c3...5529076. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2025

🧪 CI Insights

Here's what we observed from your CI run for 5529076.

❌ Job Failures

Pipeline Job Health on master Retries 🔍 CI Insights 📄 Logs
CI integration-tests Healthy 0 View View
system-tests Broken 0 View View
unit-tests Healthy 0 View View
PR CI check OAS' are up to date Unknown 0 View View

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant