🔨 Make devel-mode work again and importing in main modules ⚠️
#8515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
changed the title
devel-mode work againdevel-mode work again ⚠️
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8515 +/- ##
==========================================
- Coverage 87.52% 87.49% -0.03%
==========================================
Files 2011 2011
Lines 78591 78591
Branches 1349 1349
==========================================
- Hits 68785 68767 -18
- Misses 9402 9420 +18
Partials 404 404
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for 84bda31. ✅ Passed Jobs With Interesting Signals
|
…improve type hints
pcrespov
force-pushed
the
mai/devel-mode
branch
from
ef730b4 to
5703259
Compare
pcrespov
requested review from
GitHK,
YuryHrytsuk,
bisgaard-itis,
giancarloromeo,
mrnicegyu11,
sanderegg and
wvangeit
as code owners
pcrespov
changed the title
devel-mode work again ⚠️devel-mode work again and importing in main modules ⚠️
pcrespov
changed the title
devel-mode work again and importing in main modules ⚠️ devel-mode work again and importing in main modules ⚠️
GitHK
approved these changes
Oct 21, 2025
sanderegg
approved these changes
Oct 21, 2025
|
It looks like it works for me. I managed to start the backend in devel mode, which I never do, and since the catalog was complaining about two services, I couldn't go into the dashboard. But that's a different story, all good from my side 👍. |
|
@mergify queue |
🟠 Waiting for conditions to match
|
YuryHrytsuk
approved these changes
Oct 22, 2025
|
mrnicegyu11
approved these changes
Oct 22, 2025
wvangeit
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Fixes to ensure that
make up-develworks againdocker-api-networktodocker_api_subnetlocalcondition on this network because the override was done wrong. WARNING: check with WSL users (e.g. @odeimaiz and @sanderegg )In detail (AI generated)
This pull request makes several improvements and fixes to Docker Compose configurations and Python service entrypoints, focusing on standardizing naming conventions and import styles. The most significant changes are grouped below:
Docker Compose Naming and Configuration Fixes:
x-common-environment/*common-environmenttox-common_environment/*common_environmentindocker-compose.devel.yml, and updated all service environment references accordingly. This fixes consistency issues with YAML anchors and references. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20]docker-compose.ymlfromdocker-api-networktodocker_api_subnet, ensuring all network names use only letters and underscores to avoid Docker Compose resolution issues. [1] [2] [3]networkssection fordocker-api-networkindocker-compose.local.ymland ensured consistency in network naming.Python Service Entrypoint Import Cleanup:
APP_NAMEin the main entrypoint of several services (agent,api-server,autoscaling,dynamic-scheduler,notifications,storage) to use absolute imports instead of relative imports, improving clarity and consistency. [1] [2] [3] [4] [5] [6]Testing and Linting Improvements:
test_used_docker_compose.py, and improved subprocess call safety by adding# noqa: S602. [1] [2] [3]Other Minor Fixes:
docker-compose.local.yml.These changes collectively improve maintainability, enforce best practices, and prevent common configuration errors in the development environment.
Related issue/s
How to test
docker-composefilesDev-ops
docker-api-networktodocker_api_subnet. Might have implications in the ops compose files!!! Please double check !!!