-
Notifications
You must be signed in to change notification settings - Fork 32
✨ [Frontend] Search Files #8520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] Search Files #8520
Conversation
…core into feature/search-files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a file search feature in the frontend, allowing users to search across files in their projects using a streaming API approach. The implementation adds a new "Files" search context to the dashboard with real-time streaming of search results.
- Adds file search capability with streaming results from the backend
- Introduces new UI components for displaying and interacting with file search results
- Refactors existing date filter and navigation components for reusability
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
_simcore_s3.py | Adds filtering logic to skip empty items in file search stream |
RocketPreview.js | Adds metadata constants for Sim4Life integration |
BookACallIframe.js | Adds metadata constants for easy!appointments integration |
ConversationPage.js | Adds null check before accessing conversation object |
StreamTasks.js | New singleton store for managing streaming tasks with abort capability |
Store.js | Adds "searchFiles" context to available browser contexts |
Data.js | Implements searchFiles method to initiate file search API call |
NavigationBar.js | Refactors right-side button positioning to use explicit indices |
DateFilters.js | Refactors method naming from protected to private and improves code consistency |
File.js | New model class for file data representation |
StreamTask.js | New class for handling streaming data from long-running tasks |
Resources.js | Adds searchFiles endpoint definition |
PollTask.js | Refactors polling initialization into overridable method |
StudyBrowserHeader.js | Adds header configuration for file search context |
StudyBrowser.js | Implements main file search logic with streaming and UI integration |
SearchBarFilterExtended.js | Adds files filter button and layout changes for date filters |
ResourceContainerManager.js | Adds file list management and display capabilities |
ResourceBrowserBase.js | Refactors workspace selection method to generic location opening |
ListButtonLoadMore.js | Improves loading icon styling with consistent padding |
ListButtonBase.js | Increases default item height from 35 to 40 pixels |
FileButtonItem.js | New component for displaying individual file items with actions |
CardContainer.js | Adds FileButtonItem as valid card type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
services/storage/src/simcore_service_storage/api/_worker_tasks/_simcore_s3.py
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/store/Data.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/dashboard/SearchBarFilterExtended.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/StreamTask.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice. congratulations @giancarloromeo @odeimaiz
@odeimaiz Thanks, an incredible FE for an awesome BE! A small fix will come later to fix an issue with Folders search. |
@mergify queue |
🛑 Configuration not compatible with a branch protection settingThe branch protection setting |
What do these changes do?
This PR implements the first iteration of the file search feature in the frontend, allowing users to search across files in their projects using a streaming API approach. The implementation adds a new "Files" search context with real-time streaming of search results.
Search and open Project card:

Switching streams and reaching the end:

Related issue/s
How to test
Dev-ops