Open
Conversation
JanCBrammer
reviewed
Dec 16, 2025
Collaborator
JanCBrammer
left a comment
JanCBrammer
left a comment
There was a problem hiding this comment.
Lines are (partly) commented out in many places to change the semantics of the code. I feel like it's preferable to remove code instead of commenting it out. Down the line, commented-out code is confusing since it's not clear why it has been commented out.
Collaborator
Author
Removed commented lines. I only kept the commented function headers, because it gives you an easier overview of the required parameters. |
…into refactor_main
cm-beilstein
commented
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve #177, I had to decouple a series of functions from main to a separate file. This makes it possible to create dedicated unit tests for each function. The functions were moved to ichimain.c in INCHI-1-SRC/INCHI_BASE/src. The main was placed in a file called main.c and left in the original directory INCHI-1-SRC/INCHI_EXE/inchi-1/src. Unit tests (test_ichimain.cpp), testing the "happy-path", were created to ensure normal functionality.