Remove non-existent function base26_checksum from header#192
Merged
djb-rwth merged 1 commit intoIUPAC-InChI:devfrom Feb 8, 2026
Merged
Remove non-existent function base26_checksum from header#192djb-rwth merged 1 commit intoIUPAC-InChI:devfrom
djb-rwth merged 1 commit intoIUPAC-InChI:devfrom
Conversation
The base26_checksum implementation was removed... a long time ago. It does not belong in a header, or anything people would read to understand the structure of the current project.
Collaborator
|
Hi @Artoria2e5,
Yes, that is correct.
Unfortunately, there might be more declarations of functions which are not used either in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The base26_checksum implementation was removed... a long time ago. It does not belong in a header, or anything people would read to understand the structure of the current project.