src/lib/rinchi_hashing: Correct comment about structure of 17-char hash#28
Merged
janholstjensen merged 1 commit intoIUPAC-InChI:mainfrom Feb 9, 2026
Merged
Conversation
The 17-char hash has the first 14 chars derived from bits 0-64 (that's 65 of them) and the last 3 derived from 64-77 (that's 14 of them). chksum[8] does not, in fact, start with bit 65.
Artoria2e5
commented
Feb 7, 2026
| const std::string HASH_17_EMPTY_STRING = "UHFFFADPSCTJAUYIS"; | ||
|
|
||
| } // end of namespace | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Looks like GitHub web editor does not like NOEOL.
Collaborator
|
Thank you! Well spotted. If we could recover the bit lost the hash would improve, but for now we have to keep it as-is. At least the comment is now correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 17-char hash has the first 14 chars derived from bits 0-64 (that's 65 of them) and the last 3 derived from 64-77 (that's 14 of them). chksum[8] does not, in fact, start with bit 65.
see also: IUPAC-InChI/InChI#193