Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the getStateTextTranslated() methods in HostState and ServiceState models were incorrectly calling the text() method instead of the translated() method on their respective state classes. This would have resulted in untranslated state text being returned where translations were expected.
Changes:
- Updated HostState to call
HostStates::translated()instead ofHostStates::text() - Updated ServiceState to call
ServiceStates::translated()instead ofServiceStates::text()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| library/Icingadb/Model/HostState.php | Fixed getStateTextTranslated() to correctly call HostStates::translated() |
| library/Icingadb/Model/ServiceState.php | Fixed getStateTextTranslated() to correctly call ServiceStates::translated() (contains a typo) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public function getStateTextTranslated(): string | ||
| { | ||
| return ServiceStates::text($this->soft_state); | ||
| return ServiceStates::traslated($this->soft_state); |
There was a problem hiding this comment.
The method name "traslated" is misspelled. It should be "translated" to match the actual method name in the ServiceStates class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.