Draft
Conversation
Add a new form that supports adding and removing dispalyed columns in tabular viewmode.
Add TabularViewModeSwitcher as a subclass of ViewModeSwitcher and remove tabular view as option of the ViewModeSwitcher.
Adjust HostsController and ServicesController to use the new ColumnChooser form and the TabularViewModeSwitcher. The Controller class is adjusted to work with the TabularViewModeSwitcher The HostGroupsController and ServiceGroupsController are adjusted, to ensure they use with the GridViewModeSwitcher.
Add a button to the StateItemTable to open the ColumnChooser form.
Ensure the correct labels are displayed and the values are validated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new form to choose the displayed columns in hosts and services view.
The core functionality is implemented, but the
TabularViewModeSwitcherstill lacks its icon and the suggestions in theColumnChooserappear to be styled as regular buttons unlike other suggestions.resolves: #82