ScheduleForm: Add Send Report Now button#137
Merged
Conversation
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
2 times, most recently
from
10da1a9 to
0e0b6a6
Compare
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
0e0b6a6 to
c1024af
Compare
yhabteab
requested changes
Nov 28, 2022
Member
yhabteab
left a comment
yhabteab
left a comment
There was a problem hiding this comment.
Can't see send report now button here :)
Member
My bad! This is not the right form! 🙈 |
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
c1024af to
aa5436b
Compare
Member
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
aa5436b to
17a123f
Compare
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
17a123f to
eba5f4d
Compare
yhabteab
requested changes
Mar 15, 2023
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
eba5f4d to
e6a22d0
Compare
yhabteab
approved these changes
Mar 15, 2023
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
e6a22d0 to
d016784
Compare
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
3 times, most recently
from
79af43a to
99d479e
Compare
yhabteab
approved these changes
Mar 15, 2023
Member
|
@lippserd Do you want to have a look? |
lippserd
reviewed
Mar 15, 2023
| $action = new $values['action'](); | ||
| $action->execute($this->report, $values); | ||
|
|
||
| Notification::success(t('Report sent successfully')); |
Member
There was a problem hiding this comment.
Please replace t() with $this->translate(). After that it's free to merge.
lippserd
approved these changes
Mar 15, 2023
jhoxhaa
force-pushed
the
feature/add-send-now-button-to-schedule-form-133
branch
from
99d479e to
e4dc85e
Compare
lippserd
approved these changes
Mar 15, 2023
yhabteab
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #133