Open
Conversation
Merged
Current latest version is `3.3.0` - PHP 8.4 support was introduced in v3.2.0 (https://github.com/reactphp/promise/blob/3.x/CHANGELOG.md#320-2024-05-24). - PHP 8.5 support was inteoduced in v3.3.0 (https://github.com/reactphp/promise/releases/tag/v3.3.0)
- method resolve() requires a param - method always() is deprecated, use finally() instead - (Extended|Cancellable)PromiseInterface are removed since v3.0.0 ref https://reactphp.org/promise/changelog.html#300-2023-07-11
sukhwinder33445
force-pushed
the
upgrade-react-promise
branch
from
ea942fc to
6e2f91e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made:
react/promiseto current latest version3.3.0, for PHP 8.4/8.5 support.v3.2.0v3.3.0resolve()requires a paramalways()is deprecated, usefinally()insteadExtendedPromiseInterfacehas been replaced byPromiseInterfacesincev3.0.0The following modules use these interfaces because they implement
Task:Just for reference: There are other modules like director and vspheredb that are subject to the same changes, not because they use the scheduler, but because they use ReactPHP themselves.
refs #56