code cleanup according to best practices. #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coredeveloper
commented
Feb 6, 2021
coredeveloper
commented
- import package:example replaced with proper references.
- Scaffold.of(context, nullOk: true) used instead of unsupported Scaffold.maybeOf(context)
added 2 commits
February 6, 2021 09:55
- import package:example replaced with proper references. - Scaffold.of(context, nullOk: true) used instead of unsupported Scaffold.maybeOf(context)
- minor math optimisation - removed unused vars
archived001
approved these changes
Feb 26, 2021
miguelpruivo
requested changes
Nov 11, 2021
Collaborator
miguelpruivo
left a comment
miguelpruivo
left a comment
There was a problem hiding this comment.
Hi, this looks like a minor but good improvement to me. Could you please rebase to the latest commit and also update the pubspec/changelog?
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.