Add missing post authn test #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix error casting request_xml to bytes when request_xml is an object
Fix unsigned authentication request to POST endpoint
Member
|
All the tests failed, please fix them all, don't worry about py38, we'll fix it later |
Member
|
I reverted the repository at the commit before your merge, take your time to get the job done and don't worry, time is our allied. |
Member
|
Getting Better ... :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to commit the test as part of #167 😅
Also removed the default value of True from the construct config used in tests. Even though the stated pysaml2 default is True, this might be a little more future proof in case that default behaviour changes.