Conversation
- extend native bbclass, - fix dependencies for target (avoid using -native counterparts), - do not pull-in qt unless 'qtwpe' config is enabled, - synchronize RRECOMMENDS to PACKAGECONFIG selection. Signed-off-by: Damian Wrobel <dwrobel@ertelnet.rybnik.pl>
| inherit ${@'cmake_qt5' if 'qt5-layer' in d.getVar('BBFILE_COLLECTIONS').split() else ''} | ||
| inherit cmake pkgconfig perlnative python3native ${@bb.utils.contains('PACKAGECONFIG','qtwpe','cmake_qt5','',d)} | ||
|
|
||
| BBCLASSEXTEND = "native" |
There was a problem hiding this comment.
What is the point to make this recipe native? What other component needs wpewebkit built natively in the host?
There was a problem hiding this comment.
Maybe to use to run some automation or similar? in any case, the extend doesn't hurt.
There was a problem hiding this comment.
Sure, just I want to be sure we are not missing something else. If the change if for that reason I could suggest a small change in the commit description pointing in this direction. The current commit message makes reference to a unknown build error (wpewebkit: Fixes for cross-compilation). @dwrobel could you make this small change?
There was a problem hiding this comment.
could you make this small change?
Could you be more precise what should I change/add?
There was a problem hiding this comment.
to update the commit log message with a more clear message instead of to make reference to a unknown build error.
|
This PR is stale because it has been open 90 days with no activity. |
3 participants
Signed-off-by: Damian Wrobel dwrobel@ertelnet.rybnik.pl