Add autofocus attribute to submit button (mark as seen)#1726
Add autofocus attribute to submit button (mark as seen)#1726IgnisDa merged 2 commits intoIgnisDa:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA submit button in the metadata progress update form component now includes the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present. |
|
Haha. Done. |
|
Thanks! I will merge and release it this weekend! |

In "mark as seen" modal focus is not explicitly defined, and because of that the browser picks the first focusable element as default. From user standpoint it looks like if first element is dropdown (it usually is a season), it immediately opens. Very annoying considering mark as seen for TV shows almost always implies the currently selected episode not the different season's episode.
This fixes it by shifting focus explicitly to submit button.
Before:

After:

Summary by CodeRabbit