Skip to content

Improve display of Template and Workout names in Desktop and Mobile Views#1730

Merged
IgnisDa merged 1 commit intomainfrom
IgnisDa/issue1727
Mar 22, 2026
Merged

Improve display of Template and Workout names in Desktop and Mobile Views#1730
IgnisDa merged 1 commit intomainfrom
IgnisDa/issue1727

Conversation

@IgnisDa
Copy link
Copy Markdown
Owner

@IgnisDa IgnisDa commented Mar 22, 2026

The changes enhance the visibility of Template and Workout names by removing truncation, allowing full names to be displayed in both Desktop and Mobile views. This addresses the issue of distinguishing between different Workouts and Templates, which was previously hindered by excessive truncation.

Fixes #1727

Summary by CodeRabbit

  • Style
    • Fitness entity names now display in full without truncation, constrained to a single line
    • Timestamp presentation updated with calendar icon and formatted date, integrated into the entity statistics display

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 22, 2026

Walkthrough

Modified the fitness entity list view to display full entity names instead of truncated versions using lineClamp={1} constraint. Relocated timestamp display from a standalone text element to a formatted DisplayStat row with calendar icon, consolidating metadata presentation.

Changes

Cohort / File(s) Summary
Fitness Entity List View
apps/frontend/app/routes/_dashboard.fitness.$entity.list.tsx
Removed truncate import and usage to allow full entity name display; applied lineClamp={1} to anchor instead. Moved timestamp from separate Text element into DisplayStat row with IconCalendar and formatted date string. Added IconCalendar to tabler icon imports.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change of removing truncation and improving display of Template and Workout names across views.
Linked Issues check ✅ Passed The PR successfully addresses issue #1727 by removing truncation (lineClamp={1}), displaying full names, and improving timestamp presentation via DisplayStat.
Out of Scope Changes check ✅ Passed All changes are directly related to improving entity name display and timestamp presentation as required by issue #1727; no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch IgnisDa/issue1727

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use your project's `biome` configuration to improve the quality of JS/TS/CSS/JSON code reviews.

Add a configuration file to your project to customize how CodeRabbit runs biome.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@apps/frontend/app/routes/_dashboard.fitness`.$entity.list.tsx:
- Around line 412-421: Remove the lineClamp={1} prop from the Anchor component
(the one with component={Link}, fz and to={$path(...)} and children
entityInformation.name) so the text can wrap normally; do not add extra styling
like whiteSpace or overflowWrap—simply delete the lineClamp prop and leave the
rest of the Anchor unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9ef2058e-fd00-4554-ac80-87027e1acfc6

📥 Commits

Reviewing files that changed from the base of the PR and between 8a3450e and 314d785.

📒 Files selected for processing (1)
  • apps/frontend/app/routes/_dashboard.fitness.$entity.list.tsx

@IgnisDa IgnisDa merged commit 7934f77 into main Mar 22, 2026
14 checks passed
@IgnisDa IgnisDa deleted the IgnisDa/issue1727 branch March 22, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Template and Workout names are too truncated in Desktop and Mobile Views

1 participant