Open
Conversation
y0shi
reviewed
Mar 23, 2024
y0shi
previously requested changes
Mar 23, 2024
y0shi
requested changes
Mar 24, 2024
Member
y0shi
left a comment
y0shi
left a comment
There was a problem hiding this comment.
Looks much much better. Removing that extra code from Robot.java makes this much neater. Great job!
But... :) I think we can make it even better. The timing stuff is a little confusing to me. I think if you move it to the Timer class, it'll be easier to read and maintain. You might also be able to consolidate that logic into 1 place.
src/main/java/frc/robot/commands/lights/FlashStopLEDCommand.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controls LEDs