Skip to content

Conversation

adrianptrv
Copy link
Contributor

Closing #3746

@adrianptrv adrianptrv requested a review from simeonoff October 16, 2025 08:22
@adrianptrv adrianptrv linked an issue Oct 17, 2025 that may be closed by this pull request
@kdinev kdinev requested a review from Copilot October 18, 2025 09:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new carousel component samples to demonstrate styling capabilities - one using Tailwind CSS utility classes and another using SCSS theming. Both samples extend the existing carousel components with different styling approaches.

  • Added carousel samples with Tailwind and SCSS styling approaches
  • Integrated new components into routing and navigation structure
  • Configured live editing support for the styling sample

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/app/layouts/layouts.routes.ts Added imports and route definitions for the two new carousel samples
src/app/layouts/layouts-routes-data.ts Added display names and parent associations for the new carousel samples
src/app/layouts/carousel/carousel-tailwind-sample/* Created Tailwind-based carousel sample with CSS custom properties
src/app/layouts/carousel/carousel-styling-sample/* Created SCSS-themed carousel sample with shared layout styles
live-editing/configs/CarouselConfigGenerator.ts Added live editing configuration for the styling sample

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@@ -0,0 +1,19 @@
<div class="carousel-container">
<igx-carousel class=" ![--indicator-background:#a7b6de] ![--button-background:#a7b6de] ![--button-hover-background:#8d9abc] ![--indicator-border-color:#3E4853] ![--indicator-active-border-color:#000000] ![--button-hover-arrow-color:#000000] ![--button-arrow-color:#3E4853]">
Copy link

Copilot AI Oct 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class attribute contains an extremely long inline style definition that reduces readability and maintainability. Consider extracting these custom properties to the SCSS file or using shorter CSS class names.

Copilot uses AI. Check for mistakes.

…ing-sample.component.scss

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Carousel is missing styling samples

2 participants