Skip to content

Conversation

rkaraivanov
Copy link
Member

@rkaraivanov rkaraivanov commented Jan 6, 2025

Closes #1850

This commit migrates the combo component to use
the general key-bindings controller from the library. Aside from unifying the implementation across components this also improves several behaviors of the combo:

  • Keyboard events inside the combo are no longer "swallowed".
  • Tab navigation is more natural, i.e. there are no longer 2 tab stops per combo component.

Updated the combo test suite to accommodate for the changes.

This commit migrates the combo component to use
the general key-bindings controller from the library.
Aside from unifying the implementation across components
this also improves several behaviours of the combo:

* Keyboard events inside the combo are no longer "swallowed".
* Tab navigation is more natural, i.e. there are no longer 2 tab stops
per combo component.

Updated the combo test suite to accomodate for the
changes.
simeonoff
simeonoff previously approved these changes Jan 6, 2025
@rkaraivanov rkaraivanov added the enhancement New feature or request label Oct 2, 2025
@rkaraivanov rkaraivanov requested a review from simeonoff October 2, 2025 15:39
@ddaribo
Copy link
Contributor

ddaribo commented Oct 9, 2025

When disableFiltering is true (single-select is false), the popup is not closed and focus is not moved to the input on Up key press from the first item:
combo-test
This is a different behavior than if single-select is true. This also occurs before the refactoring.

@rkaraivanov
Copy link
Member Author

rkaraivanov commented Oct 9, 2025

@ddaribo @dkoleva-infra

I guess that is a bug/mismatch in the combo configuration. I did not find any relevant information
in the specification about what behavior should we expose, so now the combo will close its dropdown and move focus back into the main input if single-selection or disable-filtering are set.

@dkoleva-infra
If that is acceptable, can you update the specification with the new behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update Escape and Tab Key Behavior for the Combo component

4 participants