Emma changes #218
Merged
Emma changes #218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dialectiek
approved these changes
Dec 19, 2025
Dialectiek
left a comment
Dialectiek
left a comment
There was a problem hiding this comment.
Currently we have mosaik and model.pys per model (from v2) as well as v3.py per model. In this PR you delete the electrolyser v2 files, I am accepting this because we are meant to clean them up/migrate them anyways eventually but let's make a note of it.
|
NOTE: merge fail due to updated PV model, old pv model was wrong and e2e tests need to be updated, see #219 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
additions, bug fixes and dedicated models for Emma's thesis