feat: kick chat read path via pusher websocket#80
Merged
ImpulseB23 merged 3 commits intomainfrom Apr 19, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Kick chat read support end-to-end (Go sidecar Pusher client → ringbuf payload tag dispatch → Rust Kick parser), plus documentation/ADR updates describing the strategy and platform protocol.
Changes:
- Introduce Kick Pusher (protocol 7) WebSocket client in the Go sidecar and wire
kick_connect/kick_disconnectcommands. - Add 1-byte platform tag prefix on ringbuf payloads and dispatch parsing in Rust by tag.
- Implement Rust Kick Pusher event parsing into
UnifiedMessage, with unit tests; update docs/ADR for Kick API strategy.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/platform-apis.md | Document Kick auth scopes, read strategy (Pusher), write/mod endpoints, and operational constraints. |
| docs/adr.md | Add ADR 38 capturing Kick read/write/mod strategy and tag-byte framing rationale. |
| apps/desktop/src-tauri/src/message.rs | Add Kick Pusher event → UnifiedMessage parser and Kick-focused unit tests. |
| apps/desktop/src-tauri/src/host.rs | Add tag-byte dispatch in parse_batch and kick_connect command serialization helper; update tests for tagged payloads. |
| apps/desktop/src-sidecar/internal/twitch/eventsub_test.go | Update tests to account for the new Twitch tag byte prefix. |
| apps/desktop/src-sidecar/internal/twitch/eventsub.go | Prepend Twitch platform tag byte before forwarding envelopes to the shared out channel. |
| apps/desktop/src-sidecar/internal/sidecar/sidecar.go | Wire Kick connect/disconnect command handlers and manage Kick client lifecycle in the shared client registry. |
| apps/desktop/src-sidecar/internal/kick/types.go | Define Pusher/Kick message framing types used by the Kick client and tests. |
| apps/desktop/src-sidecar/internal/kick/client_test.go | Add Kick client tests for message forwarding, ping/pong handling, fatal closes, and context cancellation. |
| apps/desktop/src-sidecar/internal/kick/client.go | Implement Kick Pusher WebSocket client with reconnect backoff, subscription, and forwarding tagged events to the out channel. |
| apps/desktop/src-sidecar/internal/control/control.go | Define platform tag byte constants and extend control.Command with chatroom_id. |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
This PR has 1302 lines changed. Consider splitting it into smaller PRs for easier review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kick Pusher WebSocket client in Go, Rust parser, platform tag byte dispatch.
internal/kickpackage: Pusher protocol 7 WebSocket client with reconnect backoff, ping/pong, activity timeout, fatal close detection (4000-4099)