-
Notifications
You must be signed in to change notification settings - Fork 82
Add test execution gateway for dynamic input operator test #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wooway777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议考虑一下老pr里预想的使用方法。
| "execution_results": results, | ||
| } | ||
|
|
||
| def _save_all_results(self, save_path, total_results): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个跟reporter的save是否重复?
|
|
||
| # --- Helpers --- | ||
|
|
||
| def _discover_op_path(self, op_name: str, candidates: List[str]) -> str: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果反正都要去发现路径的话,是不是不如直接在run.py里加?然后把重复的动作提成函数去调用?
| from framework.devices import InfiniDeviceEnum | ||
|
|
||
|
|
||
| class TestCaseManager: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个要不还是交loader吧,不然manager应该包括之前的report功能才对。
其实之前那个主要也是save不是在report,考虑把两个合在一起然后叫manager也可以。
| parser.add_argument("file_path", type=str, nargs="?", help="Path to JSON config file") | ||
|
|
||
| # Overrides | ||
| parser.add_argument("--device", type=str, default=None, help="Override target device (e.g. nvidia, cpu)") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这些是一定要在这里parse么?能不能复用framework里的parsing?
Description
Add test execution gateway for dynamic input operator test.
Tests
Test json file example(inplace out = A)
Test evidence
Out of place
Inplace C
Inplace A
Inplace B