Skip to content

web: bump postcss to 8.5.12 to patch CSS stringify XSS#141

Merged
dangtony98 merged 1 commit intomainfrom
deps/bump-postcss-8.5.12
Apr 28, 2026
Merged

web: bump postcss to 8.5.12 to patch CSS stringify XSS#141
dangtony98 merged 1 commit intomainfrom
deps/bump-postcss-8.5.12

Conversation

@dangtony98
Copy link
Copy Markdown
Contributor

Summary

  • Bumps transitive postcss from 8.5.8 → 8.5.12 in web/package-lock.json via npm update postcss (the existing ^8.5.3 range from vite already permitted the fix).
  • Resolves Dependabot alert ci: bump actions/checkout from 4.2.2 to 6.0.2 #3: postcss < 8.5.10 fails to escape </style> sequences when stringifying CSS, enabling XSS in flows that re-embed user-supplied CSS into <style> tags.
  • Agent Vault does not re-stringify user CSS at runtime — postcss only runs at build time on first-party CSS — so impact here is low. Patching to clear the alert.

Test plan

  • cd web && npm run build — frontend builds clean (160 modules, no warnings)
  • CI green on the PR

🤖 Generated with Claude Code

Resolves Dependabot alert: postcss < 8.5.10 fails to escape </style>
sequences when stringifying CSS, enabling XSS in workflows that embed
re-stringified user CSS into <style> tags. Agent Vault doesn't do this
at runtime (postcss only runs at build time on first-party CSS), but
patching clears the alert.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@infisical-review-police
Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-agent-vault-141-web-bump-postcss-to-8-5-12-to-patch-css-stringify-xss

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward lockfile patch bump for postcss CVE.

Extended reasoning...

Overview

This PR is a single-file change to web/package-lock.json that bumps the transitive postcss dependency from 8.5.8 → 8.5.12 (a semver patch within the ^8.5.3 range that vite already allows). It also incidentally removes two duplicate nested tailwindcss@4.2.2 entries under @tailwindcss/node and @tailwindcss/vite, which is a normal npm dedupe side effect.

Security risks

The change is itself a security fix — it patches a known XSS vulnerability in postcss's CSS stringifier (Dependabot alert #3). No new code is introduced. As the author notes, postcss runs at build time over first-party CSS only, so the practical exposure here is minimal, but clearing the alert and keeping deps current is the right call.

Level of scrutiny

Low scrutiny is appropriate. This is a lockfile-only patch bump driven by Dependabot, no source code changes, no API or behavior changes, and the bug hunting system found nothing. The author confirmed npm run build passes locally.

Other factors

The bug hunter found no issues. The dedupe side effect is benign — both removed entries pinned the same minor version that's now resolved at the top level. CI will verify the build on the PR. No CODEOWNERS-protected files, no auth/crypto/permissions code touched.

@dangtony98 dangtony98 merged commit f0f281d into main Apr 28, 2026
9 checks passed
@dangtony98 dangtony98 deleted the deps/bump-postcss-8.5.12 branch April 28, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant