Skip to content

Conversation

@Alluneve
Copy link
Contributor

@Alluneve Alluneve commented Jun 16, 2025

  • Duty action support
  • Configuration being maintained
  • Updated Wizard Configuration JSON files to the new configuration output
  • feature when logged in, importing a stack on "JobIdx": 0 saves as the current job
  • Added Wizard import of "Duty actions 1-5 for current job"

100% sure this does not delete any legacy configurations

Sorry for the issues with 4.6.0

Update August 07, 2025:

  • Resolved merge and re-validated the functionality for 7.3
  • Removed the Wrapper component and unlinked Excel sheet references to favour a simple data container with the values we need from Lumina.Excel.Sheets.Action
  • Stopped using the GeneralActions Sheet in favour of self-crafted "Duty Action 1-5" on "RowID" 1-5 to represent Duty Actions 1 - 5
  • Updated IPC

@Alluneve
Copy link
Contributor Author

Alluneve commented Aug 7, 2025

@zbee
Hello there, and I apologise for bothering you. The IPC was your grand project after all.
This feature will have the possibility to dynamically handle whatever is in the duty action buttons with index 0-4. Example given: Variant Raise inside Variant and Criterion dungeons would be covered under these duty support actions.

For now, I added to the IPC method to include the spells inside Duty Action, should duty actions exist, and the user configured duty actions in the stack.

I do not know your consumer side, when and how often you consume the list, as this list will now be dynamic depending on the existence of duty support actions.

would love your opinion on this.

@zbee
Copy link
Contributor

zbee commented Aug 7, 2025

@Alluneve Thanks for pinging me. This sounds like exactly how I would want it to work ideally, if I understand correctly; though I'm not certain I do 😅

Sorry for the likely-silly question, but I have to head out for now so I can't dig in further myself:

Right now we're set up to check the IPC method every 20s or so for conflicts. When you say "the list will now be dynamic depending on the existence of duty support actions", you just mean that it will work normally with or without duty actions present in the game, but that the duty actions themselves would be added to the list if they're in a stack (and those duty actions are present), correct?

If that's correct then my use-case should be unaffected by your changes; But I can pull your PR tonight to double-check as well.

@Alluneve
Copy link
Contributor Author

Alluneve commented Aug 7, 2025

@zbee Functionally speaking the method will return eg: https://www.garlandtools.org/db/#action/41630 if someone has bound duty action 5 and they're inside occult cresent as a cannoneer or https://www.garlandtools.org/db/#action/29734 Variant Raise 2 during criterion dungeons, if they've bound duty action 1

@zbee
Copy link
Contributor

zbee commented Aug 7, 2025

Okay that's perfect for me then; thank you for confirming 👍🏻

# Conflicts:
#	MOAction/Configuration/MoActionStack.cs
#	MOAction/Configuration/StackEntry.cs
#	MOAction/MOAction.cs
#	MOAction/MOAction.csproj
#	MOAction/Plugin.cs
#	MOAction/Windows/Config/ConfigWindow.Settings.cs
@Alluneve
Copy link
Contributor Author

applied the 7.4 migration here too

@Infiziert90
Copy link
Owner

This needs to be updated i assume

@Alluneve
Copy link
Contributor Author

jup, will do that tonight

# Conflicts:
#	MOAction/Configuration/ConfigurationEntry.cs
#	MOAction/Configuration/MoActionStack.cs
#	MOAction/Configuration/StackEntry.cs
#	MOAction/MOAction.cs
#	MOAction/Plugin.cs
#	MOAction/Windows/Config/ConfigWindow.cs
@Alluneve
Copy link
Contributor Author

pretty sure i resolved everything wiht the merge/14.0 update now, do however definitely put this on the testing track first.

@Alluneve
Copy link
Contributor Author

finalized.

do merge with squash commit ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants