-
Notifications
You must be signed in to change notification settings - Fork 58
Duty Action support #119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Duty Action support #119
Conversation
…ouse-over Duty actions to current job when logged in
# Conflicts: # MOAction/Plugin.cs
|
@zbee For now, I added to the IPC method to include the spells inside Duty Action, should duty actions exist, and the user configured duty actions in the stack. I do not know your consumer side, when and how often you consume the list, as this list will now be dynamic depending on the existence of duty support actions. would love your opinion on this. |
|
@Alluneve Thanks for pinging me. This sounds like exactly how I would want it to work ideally, if I understand correctly; though I'm not certain I do 😅 Sorry for the likely-silly question, but I have to head out for now so I can't dig in further myself: Right now we're set up to check the IPC method every 20s or so for conflicts. When you say "the list will now be dynamic depending on the existence of duty support actions", you just mean that it will work normally with or without duty actions present in the game, but that the duty actions themselves would be added to the list if they're in a stack (and those duty actions are present), correct? If that's correct then my use-case should be unaffected by your changes; But I can pull your PR tonight to double-check as well. |
|
@zbee Functionally speaking the method will return eg: https://www.garlandtools.org/db/#action/41630 if someone has bound duty action 5 and they're inside occult cresent as a cannoneer or https://www.garlandtools.org/db/#action/29734 Variant Raise 2 during criterion dungeons, if they've bound duty action 1 |
|
Okay that's perfect for me then; thank you for confirming 👍🏻 |
# Conflicts: # MOAction/Configuration/MoActionStack.cs # MOAction/Configuration/StackEntry.cs # MOAction/MOAction.cs # MOAction/MOAction.csproj # MOAction/Plugin.cs # MOAction/Windows/Config/ConfigWindow.Settings.cs
|
applied the 7.4 migration here too |
|
This needs to be updated i assume |
|
jup, will do that tonight |
# Conflicts: # MOAction/Configuration/ConfigurationEntry.cs # MOAction/Configuration/MoActionStack.cs # MOAction/Configuration/StackEntry.cs # MOAction/MOAction.cs # MOAction/Plugin.cs # MOAction/Windows/Config/ConfigWindow.cs
|
pretty sure i resolved everything wiht the merge/14.0 update now, do however definitely put this on the testing track first. |
|
finalized. do merge with squash commit ;) |
100% sure this does not delete any legacy configurations
Sorry for the issues with 4.6.0
Update August 07, 2025: