Skip to content

feat: Update ComposeLintPlugin and define baseline at each module's level#617

Merged
LunarX merged 1 commit intomainfrom
update-compose-lint
Apr 28, 2026
Merged

feat: Update ComposeLintPlugin and define baseline at each module's level#617
LunarX merged 1 commit intomainfrom
update-compose-lint

Conversation

@LunarX
Copy link
Copy Markdown
Contributor

@LunarX LunarX commented Apr 1, 2026

@LunarX LunarX requested a review from sirambd April 1, 2026 07:48
@LunarX LunarX self-assigned this Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026 •
edited
Loading

PR Reviewer Guide 🔍

(Review updated until commit 0a5eabb)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@LunarX LunarX force-pushed the update-compose-lint branch 2 times, most recently from d26c247 to 94fa513 Compare April 2, 2026 14:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

Persistent review updated to latest commit 94fa513

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@sirambd sirambd force-pushed the update-compose-lint branch from 94fa513 to 0a5eabb Compare April 15, 2026 14:54
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

Persistent review updated to latest commit 0a5eabb

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 15, 2026

PR Code Suggestions ✨

No code suggestions found for the PR.

@LunarX LunarX force-pushed the update-compose-lint branch from 0a5eabb to 35c912a Compare April 22, 2026 11:56
Copilot AI review requested due to automatic review settings April 22, 2026 11:56
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

Failed to generate code suggestions for PR

Copilot AI reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project to use the version-catalog alias for the ComposeLintPlugin and configures an Android Lint baseline at the module level (app), aligning with the updated lint plugin setup.

Changes:

  • Replace direct Compose lint plugin ID usage in the root build script with the core.plugins.compose.lint alias.
  • Configure android.lint.baseline in the app module to use app/lint-baseline.xml.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
build.gradle.kts Switches Compose lint plugin application to the version-catalog alias.
app/build.gradle.kts Adds module-level Android Lint baseline configuration pointing to lint-baseline.xml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LunarX LunarX force-pushed the update-compose-lint branch 2 times, most recently from 012677b to c3eee47 Compare April 24, 2026 13:52
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 27, 2026

This PR/issue depends on:

@LunarX LunarX force-pushed the update-compose-lint branch from c3eee47 to ad033c8 Compare April 27, 2026 14:41
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 27, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LunarX LunarX enabled auto-merge April 27, 2026 14:46
@LunarX LunarX merged commit dc6af8c into main Apr 28, 2026
7 checks passed
@LunarX LunarX deleted the update-compose-lint branch April 28, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sirambd sirambd sirambd approved these changes

Assignees

@LunarX LunarX

Labels

Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LunarX @sirambd