feat: Add email contact picker when sending by email by amariaux · Pull Request #620 · Infomaniak/android-SwissTransfer

amariaux · 2026-04-07T08:20:07Z

Ajout d'un bouton dans la zone de saisie pour l'envoi par email, pour ouvrir la sélection de contact native.

Note: Nouvelle méthode disponible pour android 17, à regarder à sa sortie.

github-actions · 2026-04-07T08:22:14Z

PR Reviewer Guide 🔍

(Review updated until commit `a2b1da9`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Ineffective Exception Handling The try-catch block in `processContactPickerResultUri` surrounds `viewModelScope.launch`, but exceptions thrown inside the coroutine (e.g., SecurityException, IllegalStateException from ContentResolver) will not be caught because `launch` returns immediately and executes asynchronously. Any exception in `contactPickLaunch` will propagate to the global exception handler and crash the app instead of being logged to Sentry. Move the try-catch block inside the coroutine. fun processContactPickerResultUri( sessionUris: Uri, context: Context, ) { try { viewModelScope.launch { contactPickLaunch(sessionUris, context) } }catch (e: Exception){ SentryLog.e(TAG, "Error while importing contacts from picker result", e) } } Empty Email Handling In `contactPickLaunch`, the code does not filter out empty strings when reading email addresses from the contacts cursor (`data1`). Empty or blank strings from the contacts database will be added to the email list and displayed as invalid chips in the UI. Add a validation check to ensure `data1?.isNotBlank()` before processing it as an email address. val data1 = cursor.getString(data1Idx) ?: "" val email = if (mimeType == ContactsContract.CommonDataKinds.Email.CONTENT_ITEM_TYPE) data1 else null val existingContact = contactsMap[lookupKey] if (existingContact != null) { contactsMap[lookupKey] = existingContact.copy( emails = if (email != null) existingContact.emails + email else existingContact.emails, ) } else { contactsMap[lookupKey] = Contact( lookupKey = lookupKey, emails = if (email != null) listOf(email) else emptyList(), )

github-actions · 2026-04-07T08:28:36Z

Persistent review updated to latest commit a604891

github-actions · 2026-04-07T09:11:10Z

Persistent review updated to latest commit e08157e

github-actions · 2026-04-07T09:17:38Z

Persistent review updated to latest commit 2bb029a

github-actions · 2026-04-09T11:02:14Z

Persistent review updated to latest commit 573e64e

github-actions · 2026-04-09T11:26:09Z

Persistent review updated to latest commit a83cc96

github-actions · 2026-04-09T11:35:41Z

Persistent review updated to latest commit a2b1da9

…y, improve performance and avoiding threading issues

Copilot

Pull request overview

Adds a native contact-picker affordance when sending a transfer by email, allowing users to select contacts and populate recipient email addresses.

Changes:

Adds a trailing icon slot to EmailAddressTextField and wires it through the decoration box.
Adds a trailing contact-picker button in PickFilesScreen to launch the native contacts email picker (multi-select when supported).
Adds ViewModel handling to read picked contact URIs via ContentResolver and append discovered emails to recipients.
Adds localized accessibility content-description strings and a new PersonsCircleAdd vector icon.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
app/src/main/res/values/strings.xml	Adds default locale content description for the contact picker button.
app/src/main/res/values-sv/strings.xml	Adds Swedish translation for the new content description.
app/src/main/res/values-pt/strings.xml	Adds Portuguese translation for the new content description.
app/src/main/res/values-pl/strings.xml	Adds Polish translation for the new content description.
app/src/main/res/values-nl/strings.xml	Adds Dutch translation for the new content description.
app/src/main/res/values-nb/strings.xml	Adds Norwegian Bokmål translation for the new content description.
app/src/main/res/values-it/strings.xml	Adds Italian translation for the new content description.
app/src/main/res/values-fr/strings.xml	Adds French translation for the new content description.
app/src/main/res/values-fi/strings.xml	Adds Finnish translation for the new content description.
app/src/main/res/values-es/strings.xml	Adds Spanish translation for the new content description.
app/src/main/res/values-el/strings.xml	Adds Greek translation for the new content description.
app/src/main/res/values-de/strings.xml	Adds German translation for the new content description.
app/src/main/res/values-da/strings.xml	Adds Danish translation for the new content description.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/components/EmailAddressTextField.kt	Exposes `trailingIcon` support to display the picker button inside the recipient field.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt	Implements contact URI processing to extract and add recipient emails.
app/src/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesScreen.kt	Adds the trailing icon button and launches the contact picker; forwards results to the ViewModel.
app/src/main/java/com/infomaniak/swisstransfer/ui/images/icons/PersonsCircleAdd.kt	Introduces the contact-picker icon used by the new trailing button.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-24T10:01:05Z

+        try {
+            viewModelScope.launch { contactPickLaunch(sessionUris, context) }
+        } catch (e: Exception) {
+            SentryLog.e(TAG, "Error while importing contacts from picker result", e)


The try/catch here won’t catch failures thrown inside the coroutine (it only wraps the synchronous call to viewModelScope.launch). If queryContacts/contentResolver throws (e.g., SecurityException), the exception will be uncaught in viewModelScope. Wrap the body of the launched coroutine in runCatching/try-catch (or install a CoroutineExceptionHandler) so errors are logged and don’t crash/cancel the scope.

Suggested change

try {

viewModelScope.launch { contactPickLaunch(sessionUris, context) }

} catch (e: Exception) {

SentryLog.e(TAG, "Error while importing contacts from picker result", e)

viewModelScope.launch {

try {

contactPickLaunch(sessionUris, context)

} catch (e: Exception) {

SentryLog.e(TAG, "Error while importing contacts from picker result", e)

}

Copilot · 2026-04-24T10:01:05Z

+    fun processContactPickerResultUri(
+        sessionUris: Uri,
+        context: Context,
+    ) {


This ViewModel method requires a UI Context to be passed in, which forces the UI layer to thread a Context through callbacks. In this codebase, ViewModels that need a Context typically inject @ApplicationContext (e.g., SettingsSentryViewModel.kt:37-39). Consider injecting @ApplicationContext into PickFilesViewModel and using that ContentResolver instead, so callers only pass the picked Uri(s).

Copilot · 2026-04-24T10:01:05Z

+    private suspend fun updateValidatedRecipientsEmails(newEmails: Set<String>) = withContext(Dispatchers.Main) {
+        validatedRecipientsEmails = validatedRecipientsEmails + newEmails
+    }


Avoid hard-coding Dispatchers.Main inside a ViewModel when you already have injected dispatchers (ioDispatcher) and the caller coroutine resumes on Main after withContext(ioDispatcher). This extra context switch is unnecessary and makes testing harder; prefer updating state in the existing viewModelScope context or inject a Main dispatcher if needed.

Copilot · 2026-04-24T10:01:06Z

    selectedTransferType: GetSetCallbacks<TransferTypeUi>,
    transferOptionsCallbacks: TransferOptionsCallbacks,
    pickFiles: () -> Unit,
+    selectContact: (Uri, Context) -> Unit,


The selectContact callback signature includes Context, which propagates Android framework types through the composable tree and makes the API harder to reuse/test. If the ViewModel injects @ApplicationContext (see comment in PickFilesViewModel), this callback can likely be simplified to only pass the picked Uri (or a list of Uris).

Suggested change

selectContact: (Uri, Context) -> Unit,

selectContact: (Uri) -> Unit,

…utines

sonarqubecloud · 2026-04-27T08:34:26Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

amariaux requested a review from LunarX April 7, 2026 08:20

github-actions Bot assigned amariaux Apr 7, 2026

github-actions Bot added the Review effort 3/5 label Apr 7, 2026

amariaux force-pushed the contact-picker branch from d7e36fd to a604891 Compare April 7, 2026 08:24

github-actions Bot added Review effort 2/5 and removed Review effort 3/5 labels Apr 7, 2026

github-actions Bot reviewed Apr 7, 2026

View reviewed changes

github-actions Bot added Review effort 3/5 and removed Review effort 2/5 labels Apr 7, 2026

github-actions Bot reviewed Apr 7, 2026

View reviewed changes

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread ...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt

Comment thread ...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt Outdated

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread ...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt

Comment thread ...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt Outdated

github-actions Bot added Review effort 2/5 and removed Review effort 3/5 labels Apr 9, 2026

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread ...main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesViewModel.kt

Comment thread ...rc/main/java/com/infomaniak/swisstransfer/ui/screen/newtransfer/pickfiles/PickFilesScreen.kt Outdated

aymericmariaux added 8 commits April 24, 2026 11:09

feat: Add email contact picker when sending by email

0c594d9

fix: Delete comment and fix one case

ad26e03

fix: Hardcoded string and wrong accessibility content description

47ec65a

fix: Delete unused variable

8ca35f1

fix: Translation using ' instead of ’

7e3ef4f

fix: Add exception handling when launching contact picker, null safet…

7f5d268

…y, improve performance and avoiding threading issues

chore: Clean code

bf12b64

fix: Add check getting column index

c9db984

aymericmariaux force-pushed the contact-picker branch from a2b1da9 to c9db984 Compare April 24, 2026 09:10

aymericmariaux requested a review from Copilot April 24, 2026 09:12

Copilot started reviewing on behalf of aymericmariaux April 24, 2026 09:13 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

aymericmariaux added 2 commits April 24, 2026 11:46

refactor: Split contact picker logic into smaller subfunctions

aa79cf0

chore: Remove useless imports

c3b23e7

aymericmariaux requested a review from Copilot April 24, 2026 09:55

Copilot started reviewing on behalf of aymericmariaux April 24, 2026 09:56 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

aymericmariaux force-pushed the contact-picker branch from b84cb36 to 3839858 Compare April 24, 2026 10:51

refactor: Fix dispatchers, remove unused imports and unnecessary coro…

f610f42

…utines

aymericmariaux force-pushed the contact-picker branch from 3839858 to f610f42 Compare April 27, 2026 08:29

	selectContact: (Uri, Context) -> Unit,
	selectContact: (Uri) -> Unit,

Conversation

amariaux commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit a2b1da9)

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

github-actions Bot commented Apr 7, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented Apr 27, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 7, 2026 •

edited

Loading

(Review updated until commit `a2b1da9`)