Skip to content

fix: Move HomeSubDestination#143

Merged
baillyjamy merged 2 commits intomainfrom
fix-navigation-scope
Apr 29, 2026
Merged

fix: Move HomeSubDestination#143
baillyjamy merged 2 commits intomainfrom
fix-navigation-scope

Conversation

@baillyjamy
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the home navigation keys by extracting HomeSubDestination from NavDestination into its own top-level sealed interface and updates call sites accordingly.

Changes:

  • Move HomeSubDestination out of NavDestination into a standalone NavKey type.
  • Update HomeScreen to use HomeSubDestination.* directly for its nested back stack.
  • Update homeEntryProvider to register entries for HomeSubDestination.*.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
app/src/main/kotlin/com/infomaniak/auth/ui/screen/home/HomeScreen.kt Switches the home back stack to use the extracted HomeSubDestination keys.
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavigationEntryProvider.kt Registers navigation entries for HomeSubDestination instead of the previous nested NavDestination type.
app/src/main/kotlin/com/infomaniak/auth/ui/navigation/NavDestination.kt Removes nested HomeSubDestination and reintroduces it as a top-level sealed interface.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link
Copy Markdown

@baillyjamy baillyjamy merged commit a879ece into main Apr 29, 2026
9 checks passed
@baillyjamy baillyjamy deleted the fix-navigation-scope branch April 29, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants