Skip to content

chore: Switch semantic-commit workflow trigger to pull_request#755

Merged
FabianDevel merged 3 commits intomainfrom
copilot/update-semantic-commit-workflow
Apr 23, 2026
Merged

chore: Switch semantic-commit workflow trigger to pull_request#755
FabianDevel merged 3 commits intomainfrom
copilot/update-semantic-commit-workflow

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

pull_request_target runs with write permissions in the context of the base branch, which is unnecessary and a security risk for a commit-message check. Switched to pull_request instead.

  • .github/workflows/semantic-commit.yml: pull_request_targetpull_request

@FabianDevel FabianDevel force-pushed the copilot/update-semantic-commit-workflow branch from a630ca9 to 5118e73 Compare April 23, 2026 06:53
@FabianDevel FabianDevel marked this pull request as ready for review April 23, 2026 06:53
Copilot AI review requested due to automatic review settings April 23, 2026 06:53
@FabianDevel FabianDevel enabled auto-merge April 23, 2026 06:54
@FabianDevel FabianDevel changed the title Switch semantic-commit workflow trigger to pull_request chore: Switch semantic-commit workflow trigger to pull_request Apr 23, 2026
Copilot AI and others added 3 commits April 23, 2026 08:56
…aniak/.github@v2

Agent-Logs-Url: https://github.com/Infomaniak/android-core/sessions/53f755a4-b967-447a-b66f-d213861cb238

Co-authored-by: FabianDevel <45429131+FabianDevel@users.noreply.github.com>
…mmit workflow

Agent-Logs-Url: https://github.com/Infomaniak/android-core/sessions/abb0d4b5-76c5-4f7d-9c71-76962644cde4

Co-authored-by: FabianDevel <45429131+FabianDevel@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the semantic commit / PR title validation workflow to run on the less-privileged pull_request event (instead of pull_request_target), reducing exposure to base-branch write permissions for a read-only check.

Changes:

  • Switch workflow trigger from pull_request_target to pull_request.
  • Update concurrency.group to key off the PR number (instead of base ref) to avoid cross-PR cancellations.
  • Replace the inline commit-message checker job with a reusable workflow (Infomaniak/.github/.../semantic-commit.yml@v2), inheriting secrets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/semantic-commit.yml
Comment thread .github/workflows/semantic-commit.yml
Comment thread .github/workflows/semantic-commit.yml
Comment thread .github/workflows/semantic-commit.yml
@FabianDevel FabianDevel force-pushed the copilot/update-semantic-commit-workflow branch from 5118e73 to bdf4095 Compare April 23, 2026 06:56
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Failed to generate code suggestions for PR

@FabianDevel FabianDevel merged commit ab6cbb0 into main Apr 23, 2026
9 checks passed
@FabianDevel FabianDevel deleted the copilot/update-semantic-commit-workflow branch April 23, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants