Security: WebView auth token domain validation, redirect race condition, and file:// URI removal#1981
Draft
Security: WebView auth token domain validation, redirect race condition, and file:// URI removal#1981
Conversation
…file:// scheme removal Co-authored-by: sirambd <28200274+sirambd@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Explore repository for potential security vulnerabilities
Security: WebView auth token domain validation, redirect race condition, and file:// URI removal
Mar 16, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Three security vulnerabilities identified in a codebase audit, ranging from auth token leakage to unintended file access via exported components.
Changes
OnlyOfficeActivity— URL domain validation before auth header attachmentThe ****** was attached to any URL passed via intent extra, with no origin check. Added
isUrlFromTrustedDomain()that enforces HTTPS and*.infomaniak.comhost before building theAuthorizationheader. Activity finishes immediately on failure.OnlyOfficeActivity—shouldOverrideUrlLoadingrace conditionpopBackIfNeeded()callsfinish()for out-of-pattern redirects, butview.loadUrl()was called unconditionally afterward — the rejected URL briefly loaded in the WebView. Now guarded withisFinishing.AndroidManifest.xml— Removefile://scheme fromPreviewPDFActivityThe exported PDF viewer accepted
file://URIs, bypassing ContentProvider access controls. Any app could craft an intent pointing at sensitive files on shared storage. Restricted tocontent://only, which enforces proper URI permission grants.📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.