feat: Messages actions use case by solrubado · Pull Request #2819 · Infomaniak/android-kMail

solrubado · 2026-02-23T15:24:36Z

Depends on #2814

github-actions · 2026-03-03T15:23:05Z

This PR/issue depends on:

~~refactor: Network management #2814~~
By Dependent Issues (🤖). Happy coding!

FabianDevel · 2026-03-04T10:15:16Z

+    }
+
+    sealed class ApiCallResult {
+        data class Success(val messageRes: Int) : ApiCallResult()


Why did you put a message in success ? I don't think we need it

We show a success message when we do a phishing report, block user and when we successfully undo an action.

FabianDevel · 2026-03-04T10:46:38Z

-
-    private suspend fun moveOutThreadsLocally(messages: List<Message>, destinationFolder: Folder): List<String> {
-        val uidsToMove = mutableListOf<String>().apply {
-            messages.flatMapTo(mutableSetOf(), Message::threads).forEach { thread ->


I see that you now open the realm to get the thread, why do you need to do it now ?

It is safer this way, the old code could access thread.messages and it.folderId on potentially deleted objects.

FabianDevel

It appears when testing that the messages actions inside a thread may not work

FabianDevel · 2026-03-27T12:53:58Z

                    trackScheduleSendEvent(MatomoName.CustomScheduleConfirm)
                    localSettings.lastSelectedScheduleEpochMillis = timestamp
-                    mainViewModel.rescheduleDraft(Date(timestamp))
+                    actionsViewModel.rescheduleDraft(Date(timestamp), mainViewModel.currentMailbox.value!!)


You should not add new code with this nullablility check
You can manage it like elsewhere with an error snackback

FabianDevel · 2026-03-27T13:22:47Z

+                threadController.updateIsLocallyMovedOutStatus(threadsUids, hasBeenMovedOut = false)
+            }
        }
+


Revert this

FabianDevel · 2026-03-27T13:26:01Z

+        downloadThreadsStatusManager.updateState(false)
    }

+


Revert this

FabianDevel · 2026-03-27T13:42:51Z

+            threads.flatMap { thread ->
+                messageController.getLastMessageAndItsDuplicatesToExecuteAction(thread, mailbox.featureFlags)
+            }
+        } else threads.flatMap { thread -> messageController.getUnseenMessages(thread) }


Always add the brackets when the whole if cannot be inlined

FabianDevel · 2026-03-27T13:44:06Z

+                messages = messages,
+                mailbox = mailbox,
+                threadsUids = threadsUids,
+            )


oneline this

FabianDevel · 2026-03-27T14:13:32Z

+    fun updateState(isDownloading: Boolean) {
+        _isDownloading.value = isDownloading
+    }
+


Remove this line

FabianDevel · 2026-03-27T15:08:04Z


    data class UndoData(
-        val resources: List<String>,
+        val resources: List<String>?,


It doesn't need to be nullable, and the code that checks this nullability will be useless

…atus manager

…unctionm

…box with unsafe null operator

…ction Since it will be just one message, filtering is not needed, filter is just for thread actions

github-actions · 2026-04-16T07:54:50Z

Failed to generate code suggestions for PR

…ed yet

github-actions · 2026-04-17T07:18:26Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶 2814 - Partially compliant Compliant requirements: Refactored message actions into dedicated use case (MessagesActionsUseCase) Centralized API calls within the use case layer Separated business logic from ViewModels into use cases Removed direct ApiRepository calls from ViewModels Non-compliant requirements: Requires further human verification: Verify integration with android-core PR Change back dark color of NewMessage composition #700 network changes Verify that all edge cases in message actions (spam, move, delete) still handle network errors correctly with the new use case structure
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Missing Auto-Advance Logic The refactoring removed the `shouldAutoAdvance` check that was previously present in `moveThreadsOrMessageTo`. When moving threads/messages succeeds (e.g., in `createNewFolderAndMove`), the UI should auto-advance to the next item if applicable. This logic is missing in the new implementation at lines 722-730, potentially causing the UI to remain on the moved item instead of advancing. val result = messagesActionsUseCase.moveThreadsOrMessagesTo( destinationFolderId = newFolderId, threadsUids = threadsUids, messagesUids = messagesUids, mailbox = mailbox, currentFolderId = currentFolderId, ) ?: run { snackbarManager.postValue(appContext.getString(RCore.string.anErrorHasOccurred)) return@launch } with(result) { if (apiResponses.atLeastOneSucceeded()) { refreshFoldersAsync( mailbox = currentMailbox.value!!, messagesFoldersIds = messages.getFoldersIds(), destinationFolderId = newFolderId, threadsUids = threadsUids, ) showMoveSnackbar(threadsUids.count(), messages, apiResponses, destinationFolder) isMovedToNewFolder.postValue(true) } if (apiResponses.atLeastOneFailed()) { threadController.updateIsLocallyMovedOutStatus(threadsUids, hasBeenMovedOut = false) } } } Redundant Variable Shadowing Lines 604 and 622 contain redundant variable declarations `val mailbox = mailbox` that shadow the function parameters. This unnecessary code should be removed to improve readability and avoid confusion. val mailbox = mailbox

sonarqubecloud · 2026-04-17T07:21:25Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-17T07:30:38Z

Failed to generate code suggestions for PR

github-actions Bot assigned solrubado Feb 23, 2026

solrubado changed the title ~~Messages actions use case~~ feat: Messages actions use case Feb 24, 2026

github-actions Bot added the dependent This MR depends on another PR label Feb 24, 2026

FabianDevel force-pushed the network-management branch from 8a8e99a to 73350ef Compare March 3, 2026 14:34

FabianDevel force-pushed the messages-actions-use-case branch from b80a46a to 3a7ff5e Compare March 3, 2026 14:34

solrubado force-pushed the network-management branch from e6d2918 to cde5dde Compare March 3, 2026 15:11

Base automatically changed from network-management to protected/refactor-mail-actions March 3, 2026 15:22

github-actions Bot removed the dependent This MR depends on another PR label Mar 3, 2026

solrubado force-pushed the messages-actions-use-case branch from 3a7ff5e to 3db2f00 Compare March 3, 2026 15:26

FabianDevel requested changes Mar 4, 2026

View reviewed changes

solrubado force-pushed the messages-actions-use-case branch from e18fa08 to 9c6dbcf Compare March 23, 2026 14:11

FabianDevel requested changes Mar 27, 2026

View reviewed changes

solrubado force-pushed the messages-actions-use-case branch from 6a03b28 to c51c111 Compare April 15, 2026 14:39

solrubado force-pushed the protected/refactor-mail-actions branch 2 times, most recently from e8077b7 to 86a961b Compare April 16, 2026 07:23

solrubado added 14 commits April 16, 2026 09:24

fix: Improve network manager coroutine scope

795958e

refactor: Add move, spam and delete use cases

df5a28e

refactor: Add seen actions to messagesActionsUseCase

6b877e9

refactor: Add toggle favorite to messagesActionsUseCase

775e39a

refactor: Add phishing and block user to messagesActionsUseCase

a838a64

refactor: Add snooze and undo actions to messageActionsUseCase

b032540

refactor: Remove messages related functions from SharedUtils

4864ff1

refactor: Remove duplicated move code in MainViewModel

28fa307

refactor: Remove unnecesary comments, check unsafe calls

f1d7de2

refactor: Add missing commas

62526f7

fix: Fix ai suggestions

3d467f0

fix: Fix suggested changes by AI

8b40034

fix: Fix PR

412ac09

refactor: Add missing commas

3754f08

solrubado added 19 commits April 16, 2026 09:24

fix: Fix sonar issues

b197e36

fix: Fix PR review comments

0301e94

fix: Fix functions names to be consistent

35c1eef

fix: Commit missing changes on functions names

a946ca2

refactor: Change refresh folders function to MessagesActionsUseCase

599323f

refactor: Move draft actions to ActionsViewModel and use refreshAsync

2c3b4f2

fix: Remove unused undo data on permanently delete

564688f

fix: Put refresh threads in viewModels and create download threads st…

833deaf

…atus manager

fix: Remove unused functions and give threadsuids to ondownloadstop f…

17f7887

…unctionm

fix: Toggle unseen and move to new folder and changes for PR

46b31ba

fix: Fix long line

6f88356

refactor: Remove duplicated code in viewmodels

713b8fe

fix: Fix Sonar issues

c296fd8

fix: Add snackbar when move result is null

3615ebb

refactor: Add new lines after early return

6ccfe69

refactor: Remove unnecessary functions for getting messages to favorite

d671eae

fix: Undo Data doesn't require nullable resources and don't send mail…

51c031d

…box with unsafe null operator

fix: Don't filter messages before action if it comes from a message a…

bdb347c

…ction Since it will be just one message, filtering is not needed, filter is just for thread actions

fix: Fix block sender functionality

bd50647

solrubado force-pushed the messages-actions-use-case branch from c51c111 to bd50647 Compare April 16, 2026 07:29

fix: Fix message showing mailbox is null error because it wasn't load…

33b6898

…ed yet

github-actions Bot added the Review effort 4/5 label Apr 17, 2026

Conversation

solrubado commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabianDevel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 16, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

PR Reviewer Guide 🔍

Uh oh!

sonarqubecloud Bot commented Apr 17, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

solrubado commented Feb 23, 2026 •

edited

Loading