feat: Add profile picture/BIMI in mail notification by amariaux · Pull Request #2854 · Infomaniak/android-kMail

amariaux · 2026-04-08T12:34:27Z

Retrieving and passing image URLs/Initials + BIMI authorization and BitMap display via setLargeIcon

github-actions · 2026-04-08T12:38:03Z

PR Reviewer Guide 🔍

(Review updated until commit `b6312c7`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Parcelable Deserialization Error NotificationPayload was changed from Serializable to Parcelable, but line 106 still uses intent.serializableExtra() to retrieve the payload. This will always return null or throw ClassCastException because Parcelable objects cannot be retrieved via the Serializable API. Must use intent.parcelableExtra() (available via the added core-ktx dependency) to match the new Parcelable implementation. val payload = intent.serializableExtra(EXTRA_PAYLOAD) as? NotificationPayload ?: return@launch Wrong Mailbox Context for BIMI The isBimiEnabledFlow in AvatarMergedContactData uses AccountUtils.currentMailboxId, which may not match the specific mailbox being processed in showNotification(). If background sync processes multiple mailboxes, the BIMI feature flag from the wrong mailbox (the "current" one rather than the target one) could be applied to notifications. Consider checking the feature flag directly from the mailbox parameter passed to the function. val isBimiEnabled = avatarMergedContactData.isBimiEnabledFlow.first(); val mergedContacts = avatarMergedContactData.mergedContactFlow.first()

github-actions · 2026-04-08T13:00:51Z

Persistent review updated to latest commit 95c222d

github-actions · 2026-04-08T13:57:04Z

Persistent review updated to latest commit 5c925cb

github-actions · 2026-04-08T14:18:07Z

Persistent review updated to latest commit 0f4dac8

github-actions · 2026-04-09T07:43:56Z

Persistent review updated to latest commit 4fe5f78

github-actions · 2026-04-09T08:17:29Z

Persistent review updated to latest commit 063f228

github-actions · 2026-04-09T08:53:40Z

Failed to generate code suggestions for PR

github-actions · 2026-04-09T12:40:31Z

Failed to generate code suggestions for PR

github-actions · 2026-04-13T14:23:27Z

Failed to generate code suggestions for PR

Usefull for : Infomaniak/android-kMail#2854

github-actions · 2026-04-13T14:29:12Z

Persistent review updated to latest commit a2eedeb

github-actions · 2026-04-15T14:47:55Z

Persistent review updated to latest commit fab1029

github-actions · 2026-04-17T07:13:54Z

Persistent review updated to latest commit 1c84b8b

github-actions · 2026-04-17T08:41:38Z

Persistent review updated to latest commit b6312c7

github-actions · 2026-04-17T08:53:49Z

Failed to generate code suggestions for PR

Récupération et transmission des url d'image/Initials + autorisation BIMI et affichage en BitMap via setLargeIcon

…read safety

…meout

…tmap logic into core.coil Depends on : Infomaniak/android-core#742

…ption

Replace Flow with LiveData as it was unnecessary for this use case.

sonarqubecloud · 2026-04-27T12:20:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

amariaux requested a review from a team April 8, 2026 12:34

github-actions Bot assigned amariaux Apr 8, 2026

amariaux removed the request for review from a team April 8, 2026 12:34

github-actions Bot added the Review effort 3/5 label Apr 8, 2026

github-actions Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationPayload.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt Outdated

github-actions Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationPayload.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt Outdated

github-actions Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationPayload.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt Outdated

amariaux force-pushed the contact-picture-in-notification branch from 5c925cb to 0f4dac8 Compare April 8, 2026 14:15

github-actions Bot reviewed Apr 8, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/receivers/NotificationActionsReceiver.kt

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationPayload.kt Outdated

amariaux force-pushed the contact-picture-in-notification branch from 3869ab9 to 4fe5f78 Compare April 9, 2026 07:41

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

amariaux force-pushed the contact-picture-in-notification branch from b4f9fe8 to 063f228 Compare April 9, 2026 08:07

github-actions Bot reviewed Apr 9, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationPayload.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

amariaux force-pushed the contact-picture-in-notification branch from 063f228 to bfb9405 Compare April 9, 2026 08:52

amariaux requested a review from a team April 9, 2026 11:34

benjaminVadon self-requested a review April 13, 2026 05:50

benjaminVadon requested changes Apr 13, 2026

View reviewed changes

amariaux pushed a commit to Infomaniak/android-core that referenced this pull request Apr 13, 2026

feat: Added AvatarType to Bitmap logic in core.coil

87985f2

Usefull for : Infomaniak/android-kMail#2854

amariaux mentioned this pull request Apr 13, 2026

feat: Added AvatarType to Bitmap logic in core.coil Infomaniak/android-core#742

Closed

amariaux force-pushed the contact-picture-in-notification branch from a3ab2cd to a2eedeb Compare April 13, 2026 14:26

amariaux force-pushed the contact-picture-in-notification branch from 8b02c14 to fab1029 Compare April 15, 2026 14:45

github-actions Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

github-actions Bot reviewed Apr 17, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/FetchMessagesManager.kt Outdated

Comment thread app/src/main/java/com/infomaniak/mail/utils/NotificationUtils.kt

Comment thread app/src/main/java/com/infomaniak/mail/receivers/NotificationActionsReceiver.kt Outdated

aymericmariaux requested a review from benjaminVadon April 20, 2026 13:06

benjaminVadon requested changes Apr 22, 2026

View reviewed changes

aymericmariaux added 12 commits April 23, 2026 16:09

feat: Add profile picture/BIMI in mail notification

53ef0e9

Récupération et transmission des url d'image/Initials + autorisation BIMI et affichage en BitMap via setLargeIcon

fix: Fix potential crash, unused code and debug print

8282445

fix: More precise function name, factory decoder for svg, logs and th…

749bd29

…read safety

fix: Catch notification in a thread safe manner, add image loading ti…

379f53e

…meout

fix: Notification delay fix and better avatar resolution

1a01b41

fix: Correct flow to display profile picture

760046a

fix: Delete init stateflow, change stateflow to flow, move avatarToBi…

4cd5d91

…tmap logic into core.coil Depends on : Infomaniak/android-core#742

refactor: Avatar generation logic move to core

ed723b4

refactor: Reformat line breaks and remove unused dependencies

2866578

fix: Resolve potential thread access violations and NoSuchElementExce…

f965d54

…ption

fix: Change liveData to flow

352e071

fix: Detach Realm object in notification payload using copyFromRealm

93fff02

aymericmariaux force-pushed the contact-picture-in-notification branch from 0203ab9 to 93fff02 Compare April 23, 2026 14:13

refactor: Revert Flow to LiveData

28ee12d

Replace Flow with LiveData as it was unnecessary for this use case.

aymericmariaux force-pushed the contact-picture-in-notification branch from 3356b45 to 28ee12d Compare April 24, 2026 06:32

aymericmariaux requested a review from benjaminVadon April 24, 2026 09:06

benjaminVadon approved these changes Apr 27, 2026

View reviewed changes

Merge branch 'main' into contact-picture-in-notification

a5221ed

aymericmariaux merged commit 8fe126f into main Apr 27, 2026
7 checks passed

aymericmariaux deleted the contact-picture-in-notification branch April 27, 2026 12:32

Conversation

amariaux commented Apr 8, 2026 • edited by FabianDevel Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit b6312c7)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

github-actions Bot commented Apr 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 15, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

github-actions Bot commented Apr 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 27, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amariaux commented Apr 8, 2026 •

edited by FabianDevel

Loading

github-actions Bot commented Apr 8, 2026 •

edited

Loading

(Review updated until commit `b6312c7`)