feat: Attachments reminder alert added by amariaux · Pull Request #2857 · Infomaniak/android-kMail

amariaux · 2026-04-10T12:42:29Z

Ajout d'une boîte de dialogue lorsqu'une mention de pièce jointe (ou équivalent) est détectée par une expression régulière, afin de prévenir un éventuel oubli.

github-actions · 2026-04-10T12:45:01Z

PR Reviewer Guide 🔍

(Review updated until commit `d822e16`)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Regex Boundary Bug The regex patterns using `[^\\w]` (e.g., `[^\\w]jointe?s?[^\\w]`, `[^\\w]attached[^\\w]`, etc.) require a non-word character on both sides of the keyword. This means they will fail to match keywords appearing at the very beginning or end of the email body. For example, the text "I have attached the file" would match, but "attached" alone at the start of the body would not. Consider using `(?:^\|[^\\w])...(?:[^\\w]\|$)` or word boundaries with proper Unicode handling to fix this. "[^\\w]jointe?s?[^\\w]" Suspend Function Implementation The `showSubjectDialog` and `showAttachmentDialog` functions are marked as `suspend` but manually manage a `CompletableDeferred`. While functional, this is less robust than using `suspendCancellableCoroutine`, which properly handles coroutine cancellation and cleanup if the fragment is destroyed while the dialog is showing. suspend fun showSubjectDialog(scheduled : Boolean): Boolean { trackNewMessageEvent(MatomoName.SendWithoutSubject) var isConfirm = false val isSendingCanceled = CompletableDeferred<Boolean>() descriptionDialog.show( title = getString(R.string.emailWithoutSubjectTitle), description = getString(R.string.emailWithoutSubjectDescription), positiveButtonText = R.string.buttonContinue, displayLoader = false, onPositiveButtonClicked = { trackNewMessageEvent(MatomoName.SendWithoutSubjectConfirm) isConfirm = true }, onCancel = { if (scheduled) newMessageViewModel.resetScheduledDate() }, onDismiss = { isSendingCanceled.complete(!isConfirm) }) return isSendingCanceled.await() } suspend fun showAttachmentDialog(scheduled : Boolean): Boolean { trackNewMessageEvent(MatomoName.SendWithoutAttachment) var isConfirm = false val isSendingCanceled = CompletableDeferred<Boolean>() descriptionDialog.show( title = getString(R.string.attachmentsReminderTitle), description = getString(R.string.attachmentsReminderDescription), positiveButtonText = R.string.buttonContinue, displayLoader = false, onPositiveButtonClicked = { trackNewMessageEvent(MatomoName.SendWithoutAttachmentConfirm) isConfirm = true }, onCancel = { if (scheduled) newMessageViewModel.resetScheduledDate() }, onDismiss = { isSendingCanceled.complete(!isConfirm) }) return isSendingCanceled.await() }

github-actions · 2026-04-10T12:57:12Z

Failed to generate code suggestions for PR

github-actions · 2026-04-10T13:23:25Z

Failed to generate code suggestions for PR

github-actions · 2026-04-13T09:50:54Z

Failed to generate code suggestions for PR

…shot logic

Ajout des regex dans les 13 langues pour détecter dans le corp du mail l'intention d'envoyer une piece jointe Récupération des textes de descriptions pour la boite de dialogue depuis loco Ajout des variable dans Matomo Ajout du OnDismiss dans les DescriptionAlertDialog

Refactor du code pour être plus lisible

Use a JS function to retrieve only the body instead of everything

github-actions · 2026-04-21T15:18:06Z

Persistent review updated to latest commit d822e16

github-actions · 2026-04-22T06:29:23Z

Failed to generate code suggestions for PR

github-actions · 2026-04-22T06:33:21Z

Failed to generate code suggestions for PR

Copilot

Pull request overview

Adds an “attachment reminder” flow in the new-message composer: when the user mentions an attachment (via regex detection) but hasn’t added any file, the app prompts before sending.

Changes:

Introduce a multi-language attachment-keyword regex utility and wire it into the send flow to show a confirmation dialog when no attachments are present.
Replace the previous “is editor body empty” JS with a getEditorBody() function used for both AI proposition logic and attachment detection.
Add localized strings and Matomo tracking events for the new reminder dialog.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`settings.gradle.kts`	Adds `mavenLocal()` to dependency resolution repositories.
`app/src/main/res/values*/strings.xml`	Adds title/description strings for the attachment reminder dialog (multiple locales).
`app/src/main/res/raw/get_editor_body.js`	Introduces `getEditorBody()` JS helper returning editor text (excluding signature/quotes).
`app/src/main/java/com/infomaniak/mail/utils/HtmlFormatter.kt`	Renames script loader to `getEditorBodyScript()` and points to the new raw script.
`app/src/main/java/com/infomaniak/mail/utils/AttachmentsReminderRegex.kt`	Adds `AttachmentReminderUtils.hasAttachmentKeyword()` with a combined multi-language regex.
`app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt`	Adds `shouldShowAttachmentReminder()` to centralize reminder condition.
`app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageFragment.kt`	Fetches editor body via JS and shows subject/attachment confirmation dialogs before send.
`app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageAiManager.kt`	Switches AI “body blank” calculation to `getEditorBody()` result.
`app/src/main/java/com/infomaniak/mail/ui/alertDialogs/DescriptionAlertDialog.kt`	Adds optional `onDismiss` callback support to dialog API.
`app/src/main/java/com/infomaniak/mail/MatomoMail.kt`	Adds Matomo events for sending without attachment (prompt + confirm).

Comments suppressed due to low confidence (1)

app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageAiManager.kt:48

There are now unused imports (getEditorBodyScript and the INFOMANIAK_* class name constants) after switching to calling getEditorBody() directly. Kotlin treats unused imports as compilation errors, so these should be removed.

import com.infomaniak.mail.utils.HtmlFormatter.Companion.getEditorBodyScript
import com.infomaniak.mail.utils.MessageBodyUtils.INFOMANIAK_FORWARD_QUOTE_HTML_CLASS_NAME
import com.infomaniak.mail.utils.MessageBodyUtils.INFOMANIAK_REPLY_QUOTE_HTML_CLASS_NAME
import com.infomaniak.mail.utils.MessageBodyUtils.INFOMANIAK_SIGNATURE_HTML_CLASS_NAME
import com.infomaniak.mail.utils.WebViewUtils.Companion.evaluateJs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…clarity - Change visibility of showSubjectDialog and showSubjectDialog from public to private - Rename regex variable from ALL_CAPS_WITH_UNDERSCORES to lowerCamelCase - Update body to isBodyBlank to better reflect its purpose

github-actions · 2026-04-22T07:00:55Z

Failed to generate code suggestions for PR

github-actions · 2026-04-22T09:48:53Z

Failed to generate code suggestions for PR

sonarqubecloud · 2026-04-24T09:07:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-04-24T09:26:40Z

Failed to generate code suggestions for PR

github-actions Bot assigned amariaux Apr 10, 2026

github-actions Bot added the Review effort 3/5 label Apr 10, 2026

amariaux force-pushed the attachements-reminder branch from b1e411e to 8626072 Compare April 10, 2026 12:58

amariaux force-pushed the attachements-reminder branch from 0507f65 to b06d87c Compare April 13, 2026 09:25

solrubado added 22 commits April 15, 2026 09:33

feat: Add signature to rich editor

3b72668

feat: Add signature and quotes to richHtlmEditorWebView

6b31941

feat: Add everything into the mainwebview

04773c6

feat: Add everything in the same webview and add button to hide quotes

7925de8

feat: Changes in quote toggle button and in webview focus

bc97bae

refactor: Remove logs, unnused icon and use jsoupwithlogs

2d06c69

fix: Add signature before quotes if they exist

7a84c47

feat: Show images on forward

c964b66

fix: Use images cids and remove loadWithOverviewMode on new message

bdedf24

refactor: Remove unnecesary log

7db4db8

refactor: Remove unused function

b761f1f

refactor: Fix identation in style css

b4acd2b

refactor: Fix sonar issues

90f179e

feat: Add textview placeholder and change signature with js

5413554

feat: Remove splitting of mail body if it's a draft and fix save snap…

3cd4cea

…shot logic

fix: Fix cid images and webclient for attachments

19400a4

feat: Change 3 dots for text button and fix ai PR suggestions

c8c7019

fix: Fix sonar issues and add more margin to signature

b5d2431

refactor: Refactor for PR

a26eddf

fix: Remove unnecesary space

5684fa4

fix: Fix PR comments

a0b89b9

fix: Fix PR comments

9935490

aymericmariaux changed the base branch from main to rich-editor April 21, 2026 14:46

aymericmariaux added 6 commits April 21, 2026 16:55

refactor: Corrected subject and attachment validation and sending logic

1f6dd46

Refactor du code pour être plus lisible

chore: Delete log and correct if statement for PR review

6e0da32

fix: Reduce callbacks

e41c4b5

refactor: Refactor JS function checkIsEditorBodyEmpty to getEditorBody

a46b89e

fix: Check for missing attachments only in the mail body

d822e16

Use a JS function to retrieve only the body instead of everything

aymericmariaux force-pushed the attachements-reminder branch from 902aa96 to d822e16 Compare April 21, 2026 15:09

github-actions Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread app/src/main/java/com/infomaniak/mail/utils/AttachmentsReminderUtils.kt

Comment thread app/src/main/java/com/infomaniak/mail/ui/newMessage/NewMessageViewModel.kt

aymericmariaux requested a review from Copilot April 22, 2026 06:28

Copilot started reviewing on behalf of aymericmariaux April 22, 2026 06:28 View session

fix: Remove unnecessary computation

433c325

aymericmariaux force-pushed the attachements-reminder branch from fd4c9cf to 433c325 Compare April 22, 2026 06:32

Copilot AI reviewed Apr 22, 2026

View reviewed changes

aymericmariaux added 2 commits April 22, 2026 11:47

fix: Add and correct attachments reminder regex

9bade44

feat: Add test for attachments reminder regex

390fbbe

FabianDevel requested changes Apr 22, 2026

View reviewed changes

aymericmariaux added 3 commits April 24, 2026 10:50

refactor: Remove useless line breaks and variables

1d38355

fix: Remove misleading tests

34c9a5e

fix: Correct imported strings

de3ee95

aymericmariaux requested a review from FabianDevel April 24, 2026 10:54

solrubado force-pushed the rich-editor branch from 30da675 to 2f82790 Compare April 27, 2026 14:36

Conversation

amariaux commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Reviewer Guide 🔍

(Review updated until commit d822e16)

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 13, 2026

Uh oh!

github-actions Bot commented Apr 21, 2026

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

github-actions Bot commented Apr 22, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Apr 24, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Apr 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions Bot commented Apr 10, 2026 •

edited

Loading

(Review updated until commit `d822e16`)