feat: Auto-fill URL field when adding a link from selected text in the editor#2870
Open
aymericmariaux wants to merge 6 commits intorich-editorfrom
Open
feat: Auto-fill URL field when adding a link from selected text in the editor#2870aymericmariaux wants to merge 6 commits intorich-editorfrom
aymericmariaux wants to merge 6 commits intorich-editorfrom
Conversation
PR Reviewer Guide 🔍(Review updated until commit 382cfec)Here are some key observations to aid the review process:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Persistent review updated to latest commit 382cfec |
|
Failed to generate code suggestions for PR |
There was a problem hiding this comment.
Pull request overview
Adds support for pre-filling the “URL” field in the insert-link dialog when the user triggers “Add link” with a URL selected in the editor.
Changes:
- Add URL extraction helper based on
Patterns.WEB_URLto detect when selected text is a URL. - Fetch editor selected text before opening the insert-link dialog and pass it as default URL/display name values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aymericmariaux
force-pushed
the
autofill-url-from-selection
branch
2 times, most recently
from
54356c1 to
266af8c
Compare
|
Failed to generate code suggestions for PR |
aymericmariaux
force-pushed
the
autofill-url-from-selection
branch
from
c97d39f to
c3b7179
Compare
|
Failed to generate code suggestions for PR |
… in the selection
Change the selection logic to retrieve a link only if it is the sole content of the text, rather than extracting any link found within the text.
aymericmariaux
force-pushed
the
autofill-url-from-selection
branch
from
c3b7179 to
87c34c8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on : Infomaniak/android-rich-html-editor#55