fix: Include apiv2 guest transfers in transferList if needed#287
fix: Include apiv2 guest transfers in transferList if needed#287
Conversation
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
There was a problem hiding this comment.
Pull request overview
Updates transfer list aggregation so guest “API v2” transfers (stored in Room) are included alongside existing guest transfers (stored via TransferController/Realm), ensuring the UI can display a complete guest transfer list when guest data is enabled.
Changes:
- Added a
List<T>.mergeWith(...)helper to efficiently concatenate lists with empty-list fast paths. - Updated
TransferManagerguest flows (getAllTransfers,getSortedTransfers,getTransfersCount,getTransferFlow) to combine Room-backed guest transfers withTransferControllerguest transfers. - Simplified guest user references by importing
STUser.GuestUserasGuestUser.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/utils/ListExt.kt |
Adds mergeWith list concatenation helper used by transfer aggregation flows. |
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/TransferManager.kt |
Combines Room (v2) + Realm (v1) guest transfer sources in list/count/detail flows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/Infomaniak/multiplatform-SwissTransfer/sessions/6b36c3e2-c55d-4ae0-9bd5-d66ff103a86c Co-authored-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
|



No description provided.