Skip to content

fix: Include apiv2 guest transfers in transferList if needed#287

Merged
sirambd merged 6 commits intomainfrom
guest-api-v2
Apr 28, 2026
Merged

fix: Include apiv2 guest transfers in transferList if needed#287
sirambd merged 6 commits intomainfrom
guest-api-v2

Conversation

@sirambd
Copy link
Copy Markdown
Member

@sirambd sirambd commented Apr 28, 2026

No description provided.

sirambd added 4 commits April 28, 2026 09:37
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
Copilot AI review requested due to automatic review settings April 28, 2026 09:34
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates transfer list aggregation so guest “API v2” transfers (stored in Room) are included alongside existing guest transfers (stored via TransferController/Realm), ensuring the UI can display a complete guest transfer list when guest data is enabled.

Changes:

  • Added a List<T>.mergeWith(...) helper to efficiently concatenate lists with empty-list fast paths.
  • Updated TransferManager guest flows (getAllTransfers, getSortedTransfers, getTransfersCount, getTransferFlow) to combine Room-backed guest transfers with TransferController guest transfers.
  • Simplified guest user references by importing STUser.GuestUser as GuestUser.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/utils/ListExt.kt Adds mergeWith list concatenation helper used by transfer aggregation flows.
STCore/src/commonMain/kotlin/com/infomaniak/multiplatform_swisstransfer/managers/TransferManager.kt Combines Room (v2) + Realm (v1) guest transfer sources in list/count/detail flows.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 28, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED -Xmx4g -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant -cp /home/REDACTED/.gradle/wrapper/dists/gradle-8.14.4-bin/92wwslzcyst3phie3o264zltu/gradle-8.14.4/lib/gradle-daemon-main-8.14.4.jar (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Signed-off-by: Abdourahamane Boinaidi <abdourahamane.boinaidi@infomaniak.com>
@sonarqubecloud
Copy link
Copy Markdown

@sirambd sirambd merged commit 1d4868e into main Apr 28, 2026
6 checks passed
@sirambd sirambd deleted the guest-api-v2 branch April 28, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants